Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 228073004: Guard 32-bit SMI load/store optimization with SmiValuesAre32Bits predicate. (Closed)

Created:
6 years, 8 months ago by haitao.feng
Modified:
6 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Guard 32-bit SMI load/store optimization with SmiValuesAre32Bits predicate. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20634

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/x64/lithium-codegen-x64.cc View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
PTAL.
6 years, 8 months ago (2014-04-08 14:17:10 UTC) #1
Toon Verwaest
lgtm
6 years, 8 months ago (2014-04-09 14:10:04 UTC) #2
haitao.feng
6 years, 8 months ago (2014-04-10 00:32:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20634 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698