[telemetry] Refactor run_tests to remove old cruft.

[telemetry] Refactor run_tests to remove old cruft.

- Remove dead code and circuitous code paths.
- Make its API consistent with run_benchmark, taking advantage of command_line.OptparseCommand.


BUG=346956
TEST=tools/telemetry/run_tests && tools/perf/run_tests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280232

R=kbr@chromium.org, nduca@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281813

[nduca, 2014-04-08 06:30:08]

https://codereview.chromium.org/228073002/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/unittest/run_tests.py (right):

https://codereview.chromium.org/228073002/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/unittest/run_tests.py:91: config =
environment.Environment([util.GetBaseDir()])
do not like.... i can haz stateless module instead?

pass in environment for instance?


and ugh why util.GetBaseDir? Plz plz no!!!

[dtu, 2014-04-08 06:43:14]

On 2014/04/08 06:30:08, nduca wrote:
>
https://codereview.chromium.org/228073002/diff/20001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/unittest/run_tests.py (right):
> 
>
https://codereview.chromium.org/228073002/diff/20001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/unittest/run_tests.py:91: config =
> environment.Environment([util.GetBaseDir()])
> do not like.... i can haz stateless module instead?
> 
> pass in environment for instance?
> 
> 
> and ugh why util.GetBaseDir? Plz plz no!!!

I don't like it either. But the first thing is to make it consistent across
run_benchmark, run_measurement, record_wpr, and run_tests. Then we can figure
out how to plumb it through. My current thinking is to just add these things to
args, which is already plumbed through everywhere.

[dtu, 2014-04-08 06:51:57]

On 2014/04/08 06:43:14, dtu wrote:
> On 2014/04/08 06:30:08, nduca wrote:
> >
>
https://codereview.chromium.org/228073002/diff/20001/tools/telemetry/telemetr...
> > File tools/telemetry/telemetry/unittest/run_tests.py (right):
> > 
> >
>
https://codereview.chromium.org/228073002/diff/20001/tools/telemetry/telemetr...
> > tools/telemetry/telemetry/unittest/run_tests.py:91: config =
> > environment.Environment([util.GetBaseDir()])
> > do not like.... i can haz stateless module instead?
> > 
> > pass in environment for instance?
> > 
> > 
> > and ugh why util.GetBaseDir? Plz plz no!!!
> 
> I don't like it either. But the first thing is to make it consistent across
> run_benchmark, run_measurement, record_wpr, and run_tests. Then we can figure
> out how to plumb it through. My current thinking is to just add these things
to
> args, which is already plumbed through everywhere.

s/make it consistent/make it work
s/args/nouveau BrowserOptions

[dtu, 2014-04-17 18:33:06]

On 2014/04/08 06:51:57, dtu wrote:
> On 2014/04/08 06:43:14, dtu wrote:
> > On 2014/04/08 06:30:08, nduca wrote:
> > >
> >
>
https://codereview.chromium.org/228073002/diff/20001/tools/telemetry/telemetr...
> > > File tools/telemetry/telemetry/unittest/run_tests.py (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/228073002/diff/20001/tools/telemetry/telemetr...
> > > tools/telemetry/telemetry/unittest/run_tests.py:91: config =
> > > environment.Environment([util.GetBaseDir()])
> > > do not like.... i can haz stateless module instead?
> > > 
> > > pass in environment for instance?
> > > 
> > > 
> > > and ugh why util.GetBaseDir? Plz plz no!!!
> > 
> > I don't like it either. But the first thing is to make it consistent across
> > run_benchmark, run_measurement, record_wpr, and run_tests. Then we can
figure
> > out how to plumb it through. My current thinking is to just add these things
> to
> > args, which is already plumbed through everywhere.
> 
> s/make it consistent/make it work
> s/args/nouveau BrowserOptions

Friendly ping. I have a patch in progress for config/environment, but it needs
more work. Meanwhile, I have a patch for OutputFormatter that depends on this
one.

[tonyg, 2014-04-17 20:05:58]

lg2m, but Nat needs to confirm whether you've addressed his concern or not.

[nduca, 2014-04-23 23:13:16]

lgtm with some of my usual annoying questions. also http://doge2048.com/

https://codereview.chromium.org/228073002/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/unittest/run_tests.py (right):

https://codereview.chromium.org/228073002/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/unittest/run_tests.py:91: config =
environment.Environment([util.GetBaseDir()])
why called config and not environment?

why global and not passed around? might be better that everyone must pass in an
environment.

if global is required, or required for progress and can clean up later, can we
make this a _config and make a SetEnvironment(xxx)? That way once Main()
commences, we can explode on subsequent mutations of it.

[dtu, 2014-04-23 23:30:27]

On 2014/04/23 23:13:16, nduca wrote:
> lgtm with some of my usual annoying questions. also http://doge2048.com/
> 
>
https://codereview.chromium.org/228073002/diff/40001/tools/telemetry/telemetr...
> File tools/telemetry/telemetry/unittest/run_tests.py (right):
> 
>
https://codereview.chromium.org/228073002/diff/40001/tools/telemetry/telemetr...
> tools/telemetry/telemetry/unittest/run_tests.py:91: config =
> environment.Environment([util.GetBaseDir()])
> why called config and not environment?
> 
> why global and not passed around? might be better that everyone must pass in
an
> environment.
> 
> if global is required, or required for progress and can clean up later, can we
> make this a _config and make a SetEnvironment(xxx)? That way once Main()
> commences, we can explode on subsequent mutations of it.

http://flappy2048.com/

I'll make it passed around in a followup patch.

[dtu, 2014-04-23 23:30:35]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-04-23 23:31:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/228073002/40001

[commit-bot: I haz the power, 2014-04-23 23:31:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-23 23:31:36]

Failed to apply patch for tools/telemetry/telemetry/core/command_line.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file tools/telemetry/telemetry/core/command_line.py
  Hunk #1 FAILED at 68.
  Hunk #2 FAILED at 84.
  2 out of 2 hunks FAILED -- saving rejects to file
tools/telemetry/telemetry/core/command_line.py.rej

Patch:       tools/telemetry/telemetry/core/command_line.py
Index: tools/telemetry/telemetry/core/command_line.py
diff --git a/tools/telemetry/telemetry/core/command_line.py
b/tools/telemetry/telemetry/core/command_line.py
index
f9c69e1d7ecc5464d5eff6c731a1ebbc4e72d963..f671dfba7796ae9728184b469d8a712d8be445c0
100644
--- a/tools/telemetry/telemetry/core/command_line.py
+++ b/tools/telemetry/telemetry/core/command_line.py
@@ -68,7 +68,7 @@ class Command(ArgumentHandlerMixIn):
     cls.AddCommandLineArgs(parser)
     args = parser.parse_args()
     cls.ProcessCommandLineArgs(parser, args)
-    cls().Run(args)
+    return cls().Run(args)
 
 
 # TODO: Convert everything to argparse.
@@ -84,9 +84,9 @@ class OptparseCommand(Command):
 
   @classmethod
   def main(cls):
-    parser = optparse.OptionParser()
+    parser = cls.CreateParser()
     cls.AddCommandLineArgs(parser)
     options, args = parser.parse_args()
     options.positional_args = args
     cls.ProcessCommandLineArgs(parser, options)
-    cls().Run(options)
+    return cls().Run(options)

[dtu, 2014-04-23 23:57:52]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-04-23 23:58:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/228073002/60001

[commit-bot: I haz the power, 2014-04-24 00:32:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 00:32:32]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[tonyg, 2014-04-24 00:33:52]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-04-24 00:34:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/228073002/60001

[commit-bot: I haz the power, 2014-04-24 00:40:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 00:40:27]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_x64_rel

[dtu, 2014-04-24 21:04:22]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-04-24 21:08:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/228073002/80001

[commit-bot: I haz the power, 2014-04-24 22:09:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 22:09:20]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[tonyg, 2014-04-24 22:11:28]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-04-24 22:12:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/228073002/80001

[commit-bot: I haz the power, 2014-04-24 22:24:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 22:24:32]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[tonyg, 2014-04-24 22:25:12]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-04-24 22:27:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/228073002/80001

[commit-bot: I haz the power, 2014-04-24 22:42:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 22:42:04]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_x64_rel

[dtu, 2014-06-23 23:15:08]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-06-23 23:16:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtu@chromium.org/228073002/100001

[commit-bot: I haz the power, 2014-06-24 01:00:43]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-24 01:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-24 01:03:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[dtu, 2014-06-24 20:52:21]

+kbr OWNERS

[Ken Russell (switch to Gerrit), 2014-06-24 22:53:28]

content/test/gpu LGTM

[dtu, 2014-06-24 22:55:01]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-06-24 22:57:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtu@chromium.org/228073002/100001

[commit-bot: I haz the power, 2014-06-25 04:07:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-25 05:57:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-25 05:57:41]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[dtu, 2014-06-26 22:55:25]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-06-26 22:58:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtu@chromium.org/228073002/100001

[dtu, 2014-06-27 00:01:39]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-06-27 00:04:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtu@chromium.org/228073002/120001

[dtu, 2014-06-27 00:29:09]

The CQ bit was unchecked by dtu@chromium.org

[dtu, 2014-06-27 00:44:14]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-06-27 00:45:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtu@chromium.org/228073002/140001

[commit-bot: I haz the power, 2014-06-27 03:58:26]

Change committed as 280232

[Johnny, 2014-06-27 16:23:24]

A revert of this CL has been created in
https://codereview.chromium.org/355203002/ by jgraettinger@chromium.org.

The reason for reverting is: Causing builder failures, eg:
http://build.chromium.org/p/chromiumos.chromium/builders/AMD64%20%28chromium%...

Error is missing gtest_testrunner module, removed in this CL:

ERROR:root:selenium module failed to be imported.
autotest-chrome-0.0.1-r3848: ERROR:root:telemetry_UnitTests import error: cannot
import name gtest_testrunner.  Skipping telemetry_UnitTests
autotest-chrome-0.0.1-r3848: Traceback (most recent call last):
autotest-chrome-0.0.1-r3848:   File
"/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3848/work/autotest-work/client/bin/setup_job.py",
line 72, in init_test
autotest-chrome-0.0.1-r3848:     exec import_stmt + '\n' + init_stmt in
locals_dict, globals_dict
autotest-chrome-0.0.1-r3848:   File "<string>", line 1, in <module>
autotest-chrome-0.0.1-r3848:   File
"/build/amd64-generic/tmp/portage/chromeos-base/autotest-chrome-0.0.1-r3848/work/autotest-work/client/site_tests/telemetry_UnitTests/telemetry_UnitTests.py",
line 7, in <module>
autotest-chrome-0.0.1-r3848:     from telemetry.unittest import
gtest_testrunner, run_tests
autotest-chrome-0.0.1-r3848: ImportError: cannot import name gtest_testrunner.

[achuithb, 2014-06-27 20:25:16]

telemetry_UnitTests is using gtest_runner here:
https://cs.corp.google.com/#chromeos_public/src/third_party/autotest/files/cl...

[dtu, 2014-07-08 20:19:23]

Committed patchset #9 manually as r281813 (presubmit successful).