Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 22807003: Fix regressions triggered by map invalidation during graph creation. (Closed)

Created:
7 years, 4 months ago by Yang
Modified:
7 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Fix regressions triggered by map invalidation during graph creation. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16150

Patch Set 1 #

Total comments: 5

Patch Set 2 : added check #

Patch Set 3 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -29 lines) Patch
M src/assert-scope.h View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler.h View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M src/compiler.cc View 1 2 6 chunks +12 lines, -1 line 0 comments Download
M src/objects.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-map-invalidation-1.js View 1 2 1 chunk +14 lines, -11 lines 0 comments Download
A + test/mjsunit/regress/regress-map-invalidation-2.js View 1 2 1 chunk +17 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Please take a look
7 years, 4 months ago (2013-08-12 13:11:09 UTC) #1
Jakob Kummerow
LGTM with nits. See also Ben's comments on https://codereview.chromium.org/22833002/. https://codereview.chromium.org/22807003/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/22807003/diff/1/src/compiler.cc#newcode451 src/compiler.cc:451: ...
7 years, 4 months ago (2013-08-12 13:48:24 UTC) #2
Yang
7 years, 4 months ago (2013-08-12 14:10:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r16150.

Powered by Google App Engine
This is Rietveld 408576698