Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2280673002: [chromecast] Deletes all gyp files. (Closed)

Created:
4 years, 3 months ago by alokp
Modified:
4 years, 3 months ago
Reviewers:
slan
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromecast] Deletes all gyp files. BUG=617633 Committed: https://crrev.com/4e9c220e11e9965bb8b08aae3c636d87fc08be8c Cr-Commit-Position: refs/heads/master@{#414429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1813 lines) Patch
D chromecast/build/tests/test_list.gypi View 1 chunk +0 lines, -54 lines 0 comments Download
D chromecast/chromecast.gyp View 1 chunk +0 lines, -798 lines 0 comments Download
D chromecast/chromecast_locales.gyp View 1 chunk +0 lines, -69 lines 0 comments Download
D chromecast/chromecast_tests.gypi View 1 chunk +0 lines, -425 lines 0 comments Download
D chromecast/media/media.gyp View 1 chunk +0 lines, -467 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
alokp
4 years, 3 months ago (2016-08-25 13:02:34 UTC) #2
slan
lgtm - thanks!
4 years, 3 months ago (2016-08-25 13:24:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280673002/1
4 years, 3 months ago (2016-08-25 13:25:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 14:16:18 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 14:17:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e9c220e11e9965bb8b08aae3c636d87fc08be8c
Cr-Commit-Position: refs/heads/master@{#414429}

Powered by Google App Engine
This is Rietveld 408576698