Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: Source/core/animation/AnimatableLength.h

Issue 228063006: Remove special cases for viewport units, and add tests for viewport units in calc(). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Convert to interpolation test. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/css3/calc/viewport-unit-expected.html ('k') | Source/core/animation/AnimatableLength.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/AnimatableLength.h
diff --git a/Source/core/animation/AnimatableLength.h b/Source/core/animation/AnimatableLength.h
index 626a4bf42fbbd90a142b3c788d765224b5e879da..adfb136b66721b205ec5ffe030b2c2280f667987 100644
--- a/Source/core/animation/AnimatableLength.h
+++ b/Source/core/animation/AnimatableLength.h
@@ -66,7 +66,6 @@ public:
protected:
virtual PassRefPtrWillBeRawPtr<AnimatableValue> interpolateTo(const AnimatableValue*, double fraction) const OVERRIDE;
- virtual bool usesDefaultInterpolationWith(const AnimatableValue*) const OVERRIDE;
private:
AnimatableLength(double number, CSSPrimitiveValue::LengthUnitType unitType, CSSPrimitiveValue* cssPrimitiveValue)
@@ -90,14 +89,6 @@ private:
static bool isCalc(CSSPrimitiveValue::LengthUnitType type) { return type == CSSPrimitiveValue::UnitTypeCalc; }
bool isCalc() const { return isCalc(m_lengthUnitType); }
- bool isViewportUnit() const
- {
- return m_lengthUnitType == CSSPrimitiveValue::UnitTypeViewportWidth
- || m_lengthUnitType == CSSPrimitiveValue::UnitTypeViewportHeight
- || m_lengthUnitType == CSSPrimitiveValue::UnitTypeViewportMin
- || m_lengthUnitType == CSSPrimitiveValue::UnitTypeViewportMax;
- }
-
static PassRefPtrWillBeRawPtr<AnimatableLength> create(const AnimatableLength* leftAddend, const AnimatableLength* rightAddend)
{
ASSERT(leftAddend && rightAddend);
« no previous file with comments | « LayoutTests/css3/calc/viewport-unit-expected.html ('k') | Source/core/animation/AnimatableLength.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698