Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 228063002: Construct literal maps using factory constructor. (Closed)

Created:
6 years, 8 months ago by sra1
Modified:
6 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Construct literal maps using factory constructor. Fixes issue 12891 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=34836

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -20 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 5 chunks +20 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 chunk +45 lines, -9 lines 0 comments Download
M sdk/lib/_internal/lib/collection_patch.dart View 1 2 chunks +13 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/js_helper.dart View 1 1 chunk +0 lines, -4 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sra1
Saves 6k from vampire unminified.
6 years, 8 months ago (2014-04-08 04:15:00 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/228063002/diff/20001/sdk/lib/_internal/lib/collection_patch.dart File sdk/lib/_internal/lib/collection_patch.dart (right): https://codereview.chromium.org/228063002/diff/20001/sdk/lib/_internal/lib/collection_patch.dart#newcode496 sdk/lib/_internal/lib/collection_patch.dart:496: var map = new _LinkedHashMap<K, V>(); delete line
6 years, 8 months ago (2014-04-08 11:53:17 UTC) #2
floitsch
https://codereview.chromium.org/228063002/diff/20001/sdk/lib/_internal/compiler/implementation/compiler.dart File sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/228063002/diff/20001/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode1531 sdk/lib/_internal/compiler/implementation/compiler.dart:1531: Element lookupConstructor(ClassElement classElement, String name) { Is this necessary? ...
6 years, 8 months ago (2014-04-08 12:43:13 UTC) #3
sra1
https://codereview.chromium.org/228063002/diff/20001/sdk/lib/_internal/compiler/implementation/compiler.dart File sdk/lib/_internal/compiler/implementation/compiler.dart (right): https://codereview.chromium.org/228063002/diff/20001/sdk/lib/_internal/compiler/implementation/compiler.dart#newcode1531 sdk/lib/_internal/compiler/implementation/compiler.dart:1531: Element lookupConstructor(ClassElement classElement, String name) { On 2014/04/08 12:43:13, ...
6 years, 8 months ago (2014-04-08 17:55:00 UTC) #4
sra1
6 years, 8 months ago (2014-04-08 19:38:10 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r34836 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698