Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Side by Side Diff: src/compiler/verifier.cc

Issue 2280613002: Revert of [turbofan] Insert dummy values when changing from None type. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 985 matching lines...) Expand 10 before | Expand all | Expand 10 after
996 } 996 }
997 case IrOpcode::kTruncateTaggedToWord32: { 997 case IrOpcode::kTruncateTaggedToWord32: {
998 // Number /\ Tagged -> Signed32 /\ UntaggedInt32 998 // Number /\ Tagged -> Signed32 /\ UntaggedInt32
999 // TODO(neis): Activate once ChangeRepresentation works in typer. 999 // TODO(neis): Activate once ChangeRepresentation works in typer.
1000 // Type* from = Type::Intersect(Type::Number(), Type::Tagged()); 1000 // Type* from = Type::Intersect(Type::Number(), Type::Tagged());
1001 // Type* to = Type::Intersect(Type::Number(), Type::UntaggedInt32()); 1001 // Type* to = Type::Intersect(Type::Number(), Type::UntaggedInt32());
1002 // CheckValueInputIs(node, 0, from)); 1002 // CheckValueInputIs(node, 0, from));
1003 // CheckUpperIs(node, to)); 1003 // CheckUpperIs(node, to));
1004 break; 1004 break;
1005 } 1005 }
1006 case IrOpcode::kImpossibleToWord32:
1007 case IrOpcode::kImpossibleToWord64:
1008 case IrOpcode::kImpossibleToFloat32:
1009 case IrOpcode::kImpossibleToFloat64:
1010 case IrOpcode::kImpossibleToTagged:
1011 case IrOpcode::kImpossibleToBit:
1012 break;
1013
1006 case IrOpcode::kCheckBounds: 1014 case IrOpcode::kCheckBounds:
1007 CheckValueInputIs(node, 0, Type::Any()); 1015 CheckValueInputIs(node, 0, Type::Any());
1008 CheckValueInputIs(node, 1, Type::Unsigned31()); 1016 CheckValueInputIs(node, 1, Type::Unsigned31());
1009 CheckUpperIs(node, Type::Unsigned31()); 1017 CheckUpperIs(node, Type::Unsigned31());
1010 break; 1018 break;
1011 case IrOpcode::kCheckMaps: 1019 case IrOpcode::kCheckMaps:
1012 // (Any, Internal, ..., Internal) -> Any 1020 // (Any, Internal, ..., Internal) -> Any
1013 CheckValueInputIs(node, 0, Type::Any()); 1021 CheckValueInputIs(node, 0, Type::Any());
1014 for (int i = 1; i < node->op()->ValueInputCount(); ++i) { 1022 for (int i = 1; i < node->op()->ValueInputCount(); ++i) {
1015 CheckValueInputIs(node, i, Type::Internal()); 1023 CheckValueInputIs(node, i, Type::Internal());
(...skipping 582 matching lines...) Expand 10 before | Expand all | Expand 10 after
1598 replacement->op()->EffectOutputCount() > 0); 1606 replacement->op()->EffectOutputCount() > 0);
1599 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1607 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1600 replacement->opcode() == IrOpcode::kFrameState); 1608 replacement->opcode() == IrOpcode::kFrameState);
1601 } 1609 }
1602 1610
1603 #endif // DEBUG 1611 #endif // DEBUG
1604 1612
1605 } // namespace compiler 1613 } // namespace compiler
1606 } // namespace internal 1614 } // namespace internal
1607 } // namespace v8 1615 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | src/compiler/x64/code-generator-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698