Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2280563003: Fix Gerrit git cl land and add test. (Closed)

Created:
4 years, 3 months ago by tandrii(chromium)
Modified:
4 years, 3 months ago
Reviewers:
Bons, Michael Achenbach
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : add test that shows problem #

Patch Set 2 : Fix code and finish test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M git_cl.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests/git_cl_test.py View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
Michael Achenbach
lgtm
4 years, 3 months ago (2016-08-29 12:54:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280563003/20001
4 years, 3 months ago (2016-08-29 12:57:47 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 13:05:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/c4344b595829e0...

Powered by Google App Engine
This is Rietveld 408576698