Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: components/ntp_snippets/content_suggestions_service_unittest.cc

Issue 2280543003: Remove snippet_id from ImageFetchedCallback (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_service_unittest.cc
diff --git a/components/ntp_snippets/content_suggestions_service_unittest.cc b/components/ntp_snippets/content_suggestions_service_unittest.cc
index eca4a00b382a677bc6a0d1806c0fd6aab6d49ded..da3af1303afb85c9188a4fdee8408f4c6d10767a 100644
--- a/components/ntp_snippets/content_suggestions_service_unittest.cc
+++ b/components/ntp_snippets/content_suggestions_service_unittest.cc
@@ -191,8 +191,7 @@ class ContentSuggestionsServiceTest : public testing::Test {
return result;
}
- MOCK_METHOD2(OnImageFetched,
- void(const std::string& suggestion_id, const gfx::Image&));
+ MOCK_METHOD1(OnImageFetched, void(const gfx::Image&));
protected:
void CreateContentSuggestionsService(
@@ -297,8 +296,7 @@ TEST_F(ContentSuggestionsServiceTest,
base::RunLoop run_loop;
std::string suggestion_id = "TestID";
- EXPECT_CALL(*this, OnImageFetched(suggestion_id,
- Property(&gfx::Image::IsEmpty, Eq(true))))
+ EXPECT_CALL(*this, OnImageFetched(Property(&gfx::Image::IsEmpty, Eq(true))))
.WillOnce(InvokeWithoutArgs(&run_loop, &base::RunLoop::Quit));
service()->FetchSuggestionImage(
suggestion_id, base::Bind(&ContentSuggestionsServiceTest::OnImageFetched,
« no previous file with comments | « components/ntp_snippets/content_suggestions_service.cc ('k') | components/ntp_snippets/ntp_snippets_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698