Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2280533004: Add a GN build configuration for controlling stack frame generation. (Closed)

Created:
4 years, 3 months ago by vmiura
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a GN build configuration for controlling stack frame generation. This is part 1 of staging crrev.com/2266073002. Part 1: Add empty config("default_stack_frames"). Part 2: Disable this config in third_party/ffmpeg. Part 3: Move Chromium -fomit/-fno-omit-frame-pointer logic into this config. TBR=brettw@chromium.org TBR=dpranke@chromium.org BUG=636489 Committed: https://crrev.com/d3b4af41bc9b058a3548b2beda4cf1d1e84c68e6 Cr-Commit-Position: refs/heads/master@{#414618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280533004/1
4 years, 3 months ago (2016-08-25 23:49:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 01:33:40 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 01:37:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d3b4af41bc9b058a3548b2beda4cf1d1e84c68e6
Cr-Commit-Position: refs/heads/master@{#414618}

Powered by Google App Engine
This is Rietveld 408576698