third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h - Issue 2280513004: Restore a collapsed trailing space of text used for line break

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

Issue 2280513004: Restore a collapsed trailing space of text used for line break (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/editing/selection/caret-at-bidi-boundary-expected.txt ('K') | « third_party/WebKit/Source/core/layout/api/LineLayoutItem.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

diff --git a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

index c203467ba4fa2fc68bee0534f95a68392d6216a0..585ca0d0cbd7eaf14a4eb28019d479f965879438 100644

--- a/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

+++ b/third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h

@@ -1159,6 +1159,13 @@ inline void BreakingContext::commitAndUpdateLineBreakIfNeeded()

if (m_width.committedWidth()) {

m_atEnd = true;

+ // When the leading or trailing space of text is collapsed and a line break is inserted instead of it,

+ // we need to restore the space while the text is copied(ctrl+c). See http://crbug.com/318925

+ if (m_lastObject && m_lastObject.isText() && m_current.getLineLayoutItem().isText()) {

+ LineLayoutText lastLayoutText(m_lastObject);

+ if (lastLayoutText.text().endsWith(' '))

+ lastLayoutText.setNeedToRestoreCollapsedSpace(true);

+ }

return;

}