Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: tools/determinism/remove_build_metadata.py

Issue 2280513003: Add a blacklist for the files that should be processed by zap_timestamps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/determinism/remove_build_metadata.py
diff --git a/tools/determinism/remove_build_metadata.py b/tools/determinism/remove_build_metadata.py
index 97a63782aee03aace777959b614b1dd03c2a1b7f..bf6c2d328960ea864ccc3b3b31a734fd82b9b857 100755
--- a/tools/determinism/remove_build_metadata.py
+++ b/tools/determinism/remove_build_metadata.py
@@ -20,6 +20,10 @@ import zipfile
BASE_DIR = os.path.dirname(os.path.abspath(__file__))
SRC_DIR = os.path.dirname(os.path.dirname(BASE_DIR))
+# Files that can't be processed by zap_timestamp.exe.
+_ZAP_TIMESTAMP_BLACKLIST = {
+ 'mini_installer.exe',
+}
def get_files_to_clean(build_dir, recursive=False):
"""Get the list of files to clean."""
@@ -67,7 +71,8 @@ def remove_pe_metadata(filename):
"""Remove the build metadata from a PE file."""
# Only run zap_timestamp on the PE files for which we have a PDB.
ret = 0
- if os.path.exists(filename + '.pdb'):
+ if ((not os.path.basename(filename) in _ZAP_TIMESTAMP_BLACKLIST) and
+ os.path.exists(filename + '.pdb')):
ret = run_zap_timestamp(filename)
return ret
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698