Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2280493002:
fix for Chrome web browser does not minimize when touched. (Closed)
|
Created:
4 years, 4 months ago by xiaoyinh(OOO Sep 11-29) Modified:
4 years, 3 months ago Reviewers:
stevenjb CC:
chromium-reviews, kalyank, sadrul Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionfix for Chrome web browser does not minimize when touched.
event type is not initialized as bitmap, and should be
compared with ==.
In this case, some touch/gesture events are treated as
ui::ET_KEY_RELEASED and web browser did not get activated when touched.
BUG=623735
Committed: https://crrev.com/3738b46fe8caa61fb134498fb45441d9ba8b3390
Cr-Commit-Position: refs/heads/master@{#414542}
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 20 (15 generated)
Description was changed from ========== fix for Chrome web browser does not minimize when touched. BUG=623735 ========== to ========== fix for Chrome web browser does not minimize when touched. event type is not initialized as bitmap, and should be compared with ==. In this case, some touch/gesture events are treated as ui::ET_KEY_RELEASED and web browser did not get activated when touched. BUG=623735 ==========
xiaoyinh@chromium.org changed reviewers: + stevenjb@chromium.org
Description was changed from ========== fix for Chrome web browser does not minimize when touched. event type is not initialized as bitmap, and should be compared with ==. In this case, some touch/gesture events are treated as ui::ET_KEY_RELEASED and web browser did not get activated when touched. BUG=623735 ========== to ========== fix for Chrome web browser does not minimize when touched. event type is not initialized as bitmap, and should be compared with ==. In this case, some touch/gesture events are treated as ui::ET_KEY_RELEASED and web browser did not get activated when touched. BUG=623735 ==========
The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run
stevenjb@, please take a look. Thanks!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by xiaoyinh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org Link to the patchset: https://codereview.chromium.org/2280493002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== fix for Chrome web browser does not minimize when touched. event type is not initialized as bitmap, and should be compared with ==. In this case, some touch/gesture events are treated as ui::ET_KEY_RELEASED and web browser did not get activated when touched. BUG=623735 ========== to ========== fix for Chrome web browser does not minimize when touched. event type is not initialized as bitmap, and should be compared with ==. In this case, some touch/gesture events are treated as ui::ET_KEY_RELEASED and web browser did not get activated when touched. BUG=623735 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== fix for Chrome web browser does not minimize when touched. event type is not initialized as bitmap, and should be compared with ==. In this case, some touch/gesture events are treated as ui::ET_KEY_RELEASED and web browser did not get activated when touched. BUG=623735 ========== to ========== fix for Chrome web browser does not minimize when touched. event type is not initialized as bitmap, and should be compared with ==. In this case, some touch/gesture events are treated as ui::ET_KEY_RELEASED and web browser did not get activated when touched. BUG=623735 Committed: https://crrev.com/3738b46fe8caa61fb134498fb45441d9ba8b3390 Cr-Commit-Position: refs/heads/master@{#414542} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3738b46fe8caa61fb134498fb45441d9ba8b3390 Cr-Commit-Position: refs/heads/master@{#414542} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
