Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1921)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 2280473002: Add crash keys to debug causes of a crash in RenderFrameImpl::CreateFrame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index be2f9b1376bf5c2994b23b544c0bbdf9f6e7081f..a5d01eaf7c0620f4acfbd2fc46e4f692c8321ca3 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -74,6 +74,7 @@
#include "content/common/render_process_messages.h"
#include "content/common/resource_messages.h"
#include "content/common/service_worker/embedded_worker_setup.mojom.h"
+#include "content/common/site_isolation_policy.h"
#include "content/common/view_messages.h"
#include "content/common/worker_messages.h"
#include "content/public/common/content_constants.h"
@@ -1723,6 +1724,24 @@ void RenderThreadImpl::OnProcessPurgeAndSuspend() {
}
void RenderThreadImpl::OnCreateNewFrame(FrameMsg_NewFrame_Params params) {
+ // Debug cases of https://crbug.com/626802.
+ base::debug::SetCrashKeyValue("newframe_routing_id",
+ base::IntToString(params.routing_id));
+ base::debug::SetCrashKeyValue("newframe_proxy_id",
+ base::IntToString(params.proxy_routing_id));
+ base::debug::SetCrashKeyValue("newframe_opener_id",
+ base::IntToString(params.opener_routing_id));
+ base::debug::SetCrashKeyValue("newframe_parent_id",
+ base::IntToString(params.parent_routing_id));
+ base::debug::SetCrashKeyValue("newframe_widget_id",
+ base::IntToString(
+ params.widget_params.routing_id));
+ base::debug::SetCrashKeyValue("newframe_widget_hidden",
+ params.widget_params.hidden ? "yes" : "no");
+ base::debug::SetCrashKeyValue("newframe_replicated_origin",
+ params.replication_state.origin.Serialize());
+ base::debug::SetCrashKeyValue("newframe_oopifs_possible",
+ SiteIsolationPolicy::AreCrossProcessFramesPossible() ? "yes" : "no");
CompositorDependencies* compositor_deps = this;
RenderFrameImpl::CreateFrame(
params.routing_id, params.proxy_routing_id, params.opener_routing_id,
« chrome/app/chrome_crash_reporter_client_win.cc ('K') | « chrome/common/crash_keys.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698