Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2280463002: fix #27134, future unions in downwards generic method inference (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
Leaf, scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #27134, future unions in downwards generic method inference R=leafp@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/832f0b00737481484adcccb4e18c37f15464e5c1

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 1 2 chunks +2 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/src/generated/type_system.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
4 years, 4 months ago (2016-08-24 23:35:52 UTC) #2
scheglov
LGTM
4 years, 4 months ago (2016-08-24 23:46:41 UTC) #3
Leaf
lgtm
4 years, 4 months ago (2016-08-24 23:56:50 UTC) #4
Jennifer Messerly
4 years, 4 months ago (2016-08-24 23:58:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
832f0b00737481484adcccb4e18c37f15464e5c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698