[MD settings] "dense" paper toggle buttons

[MD settings] "dense" paper toggle buttons

This CL changes the size and color of the paper toggle buttons to better
match the mocks.

BUG=597879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true

Committed: https://crrev.com/e6124d0e6bffe30ffc252b08ee4ded2370c737d3
Cr-Commit-Position: refs/heads/master@{#415443}

[dschuyler, 2016-08-27 01:40:22]

Description was changed from

==========
[MD settings] "dense" paper toggle buttons

This CL changes the size and color of the paper toggle buttons to better
match the mocks.

BUG=597879
==========

to

==========
[MD settings] "dense" paper toggle buttons

This CL changes the size and color of the paper toggle buttons to better
match the mocks.

BUG=597879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-08-27 01:40:24]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-27 01:40:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-08-27 01:41:06]

dschuyler@chromium.org changed reviewers:
+ hcarmona@chromium.org

[commit-bot: I haz the power, 2016-08-27 03:42:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-27 03:43:00]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2016-08-29 18:15:52]

lgtm

[dschuyler, 2016-08-29 18:25:20]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-08-29 18:42:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-08-29 18:53:43]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-08-29 18:53:43]

https://codereview.chromium.org/2280333002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2280333002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_vars_css.html:84:
--settings-toggle-button-color: var(--google-blue-500);
why are you declaring these AFTER using them?  does this work with native custom
css props?

[Dan Beam, 2016-08-29 18:55:18]

https://codereview.chromium.org/2280333002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2280333002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_vars_css.html:41: width:
var(--settings-toggle-button-bar-width);
additional tip:

--settings-toggle-height-and-width: {
  height: 12px;
  width: 28px;
};

--paper-toggle-button-checked-button: var(--settings-toggle-height-and-width);
--paper-toggle-button-unchecked-button: var(--settings-toggle-height-and-width);

[Dan Beam, 2016-08-29 19:47:18]

The CQ bit was unchecked by dbeam@chromium.org

[dschuyler, 2016-08-29 23:48:13]

https://codereview.chromium.org/2280333002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2280333002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_vars_css.html:41: width:
var(--settings-toggle-button-bar-width);
On 2016/08/29 18:55:18, Dan Beam wrote:
> additional tip:
> 
> --settings-toggle-height-and-width: {
>   height: 12px;
>   width: 28px;
> };
> 
> --paper-toggle-button-checked-button: var(--settings-toggle-height-and-width);
> --paper-toggle-button-unchecked-button:
var(--settings-toggle-height-and-width);

This works iff the the --settings vars are declared before they are
used. Using the vars within the {} allows the --settings vars to be
sorted. I'm assuming that replacements are something akin to a 
breadth-first traversal (based on the behavior I'm seeing).

I can make the values unsorted and use this method if that's preferred.

https://codereview.chromium.org/2280333002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_vars_css.html:84:
--settings-toggle-button-color: var(--google-blue-500);
On 2016/08/29 18:53:43, Dan Beam wrote:
> why are you declaring these AFTER using them?  does this work with native
custom
> css props?

I had defined them above and then got a notice when trying
to submit the CL that they should be alphabetical. I tested
and it seemed to work. I didn't specifically test native
vs. non-native.

[dschuyler, 2016-08-29 23:53:30]

On 2016/08/29 23:48:13, dschuyler wrote:
>
https://codereview.chromium.org/2280333002/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/settings_vars_css.html (right):
> 
>
https://codereview.chromium.org/2280333002/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/settings_vars_css.html:41: width:
> var(--settings-toggle-button-bar-width);
> On 2016/08/29 18:55:18, Dan Beam wrote:
> > additional tip:
> > 
> > --settings-toggle-height-and-width: {
> >   height: 12px;
> >   width: 28px;
> > };
> > 
> > --paper-toggle-button-checked-button:
var(--settings-toggle-height-and-width);
> > --paper-toggle-button-unchecked-button:
> var(--settings-toggle-height-and-width);
> 
> This works iff the the --settings vars are declared before they are
> used. Using the vars within the {} allows the --settings vars to be
> sorted. I'm assuming that replacements are something akin to a 
> breadth-first traversal (based on the behavior I'm seeing).
> 
> I can make the values unsorted and use this method if that's preferred.
> 
>
https://codereview.chromium.org/2280333002/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/settings_vars_css.html:84:
> --settings-toggle-button-color: var(--google-blue-500);
> On 2016/08/29 18:53:43, Dan Beam wrote:
> > why are you declaring these AFTER using them?  does this work with native
> custom
> > css props?
> 
> I had defined them above and then got a notice when trying
> to submit the CL that they should be alphabetical. I tested
> and it seemed to work. I didn't specifically test native
> vs. non-native.

Hmm, using the vars in this other way doesn't trigger the notice
about the vars being unsorted. I'm not clear on why.
See https://codereview.chromium.org/2290033002/

[dschuyler, 2016-08-30 00:03:14]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2016-08-30 00:04:33]

Given the findings above, I've moved the vars
and changed to the other var definitions.

[Dan Beam, 2016-08-30 00:12:58]

lgtm

https://codereview.chromium.org/2280333002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2280333002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_vars_css.html:34: }
nit: technically these should end with ;

[dschuyler, 2016-08-30 00:19:34]

On 2016/08/30 00:12:58, Dan Beam wrote:
> lgtm
> 
>
https://codereview.chromium.org/2280333002/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/settings/settings_vars_css.html (right):
> 
>
https://codereview.chromium.org/2280333002/diff/20001/chrome/browser/resource...
> chrome/browser/resources/settings/settings_vars_css.html:34: }
> nit: technically these should end with ;

Ah! Adding the semi-colons makes the presubmit notice them
and warn about alphabetizing the list :)

So now there's the choice of going with Patch #1 or Patch #3
(with the semi-colons) and bypass the presubmit.

WDYT

[Dan Beam, 2016-08-30 00:20:15]

On 2016/08/30 00:19:34, dschuyler wrote:
> On 2016/08/30 00:12:58, Dan Beam wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/2280333002/diff/20001/chrome/browser/resource...
> > File chrome/browser/resources/settings/settings_vars_css.html (right):
> > 
> >
>
https://codereview.chromium.org/2280333002/diff/20001/chrome/browser/resource...
> > chrome/browser/resources/settings/settings_vars_css.html:34: }
> > nit: technically these should end with ;
> 
> Ah! Adding the semi-colons makes the presubmit notice them
> and warn about alphabetizing the list :)
> 
> So now there's the choice of going with Patch #1 or Patch #3
> (with the semi-colons) and bypass the presubmit.
> 
> WDYT

bypass the presubmit

[dschuyler, 2016-08-30 00:23:30]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 00:57:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:35:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:35:49]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dschuyler, 2016-08-30 21:46:39]

Description was changed from

==========
[MD settings] "dense" paper toggle buttons

This CL changes the size and color of the paper toggle buttons to better
match the mocks.

BUG=597879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] "dense" paper toggle buttons

This CL changes the size and color of the paper toggle buttons to better
match the mocks.

BUG=597879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true
==========

[dschuyler, 2016-08-30 21:46:45]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-08-30 21:46:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
hcarmona@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2280333002/#ps40001
(title: "added semi-colons")

[commit-bot: I haz the power, 2016-08-30 21:47:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 21:49:21]

Description was changed from

==========
[MD settings] "dense" paper toggle buttons

This CL changes the size and color of the paper toggle buttons to better
match the mocks.

BUG=597879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true
==========

to

==========
[MD settings] "dense" paper toggle buttons

This CL changes the size and color of the paper toggle buttons to better
match the mocks.

BUG=597879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true
==========

[commit-bot: I haz the power, 2016-08-30 21:49:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-30 21:51:39]

Description was changed from

==========
[MD settings] "dense" paper toggle buttons

This CL changes the size and color of the paper toggle buttons to better
match the mocks.

BUG=597879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true
==========

to

==========
[MD settings] "dense" paper toggle buttons

This CL changes the size and color of the paper toggle buttons to better
match the mocks.

BUG=597879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true

Committed: https://crrev.com/e6124d0e6bffe30ffc252b08ee4ded2370c737d3
Cr-Commit-Position: refs/heads/master@{#415443}
==========

[commit-bot: I haz the power, 2016-08-30 21:51:40]

Patchset 3 (id:??) landed as
https://crrev.com/e6124d0e6bffe30ffc252b08ee4ded2370c737d3
Cr-Commit-Position: refs/heads/master@{#415443}