Source/core/dom/Element.cpp - Issue 22803008: setAttributeNode() does not properly normalize case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 22803008: setAttributeNode() does not properly normalize case. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: submitting patch with small name changes. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index 88c62a904d844a492aa38be6c2499b0bccb913ae..2408c1d5fac57054f2b4adce2fc712e4d4d51acb 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -1837,7 +1837,7 @@ PassRefPtr<Attr> Element::setAttributeNode(Attr* attrNode, ExceptionState& es)

synchronizeAllAttributes();

UniqueElementData* elementData = ensureUniqueElementData();

- size_t index = elementData->getAttributeItemIndex(attrNode->qualifiedName());

+ size_t index = elementData->getAttributeItemIndex(attrNode->qualifiedName(), shouldIgnoreAttributeCase(this));

if (index != notFound) {

if (oldAttrNode)

detachAttrNodeFromElementWithValue(oldAttrNode.get(), elementData->attributeItem(index)->value());

« no previous file with comments | « Source/core/dom/Element.h ('k') | Source/core/dom/QualifiedName.h » ('j') | no next file with comments »