Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2280283002: Convert RTCPeerConnection-AddRemoveStream tests from js-test to testharness.js (Closed)

Created:
4 years, 3 months ago by jeffcarp
Modified:
4 years, 3 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert RTCPeerConnection-AddRemoveStream tests from js-test to testharness.js BUG=614963 Committed: https://crrev.com/a6a1bca0b0b021cd18b0f4fdb2b557d573d08da8 Cr-Commit-Position: refs/heads/master@{#415705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -89 lines) Patch
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-AddRemoveStream.html View 1 chunk +35 lines, -70 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-AddRemoveStream-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jeffcarp
4 years, 3 months ago (2016-08-26 23:55:08 UTC) #2
jeffcarp
On 2016/08/26 at 23:55:08, jeffcarp wrote: > I tried something different in this one - ...
4 years, 3 months ago (2016-08-26 23:56:47 UTC) #3
jeffcarp
On 2016/08/26 at 23:56:47, jeffcarp wrote: > On 2016/08/26 at 23:55:08, jeffcarp wrote: > > ...
4 years, 3 months ago (2016-08-26 23:58:43 UTC) #4
Guido Urdaneta
lgtm
4 years, 3 months ago (2016-08-29 10:02:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280283002/1
4 years, 3 months ago (2016-08-31 17:29:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 18:56:00 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 18:57:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6a1bca0b0b021cd18b0f4fdb2b557d573d08da8
Cr-Commit-Position: refs/heads/master@{#415705}

Powered by Google App Engine
This is Rietveld 408576698