Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2280233004: Don't play new animation on external intents (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 531233d86adcca405a9590f684554f8587d2645e..e4516704b844dbf988ed4a45b330130a1d1772ca 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -792,8 +792,12 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
break;
case OPEN_NEW_INCOGNITO_TAB:
if (url == null || url.equals(UrlConstants.NTP_URL)) {
- if (fromLauncherShortcut) recordLauncherShortcutAction(true);
- if (TextUtils.equals(externalAppId, getPackageName())) {
+ TabLaunchType launchType;
+ if (fromLauncherShortcut) {
+ getTabCreator(true).launchUrl(
+ UrlConstants.NTP_URL, TabLaunchType.FROM_EXTERNAL_APP);
+ recordLauncherShortcutAction(true);
+ } else if (TextUtils.equals(externalAppId, getPackageName())) {
// Used by the Account management screen to open a new incognito tab.
// Account management screen collects its metrics separately.
getTabCreator(true).launchUrl(
@@ -1291,7 +1295,8 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
intent, IntentHandler.EXTRA_INVOKED_FROM_SHORTCUT, false);
return getTabCreator(isIncognito).launchUrl(
url,
- fromLauncherShortcut ? TabLaunchType.FROM_CHROME_UI : TabLaunchType.FROM_LINK,
+ fromLauncherShortcut ? TabLaunchType.FROM_EXTERNAL_APP
+ : TabLaunchType.FROM_LINK,
intent,
mIntentHandlingTimeMs);
} else {
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698