[HBD] Update MD Site Settings Plugins section to show 3rd mode checkbox.

chrome/browser/resources/settings/site_settings/site_settings_behavior.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Behavior common to Site Settings classes.
  */
 
 /** @polymerBehavior */
 var SiteSettingsBehaviorImpl = {
@@ skipping 230 matching lines @@
         return loadTimeData.getString('siteSettingsUsbDevices');
       default:
         assertNotReached('Invalid category: ' + category);
         return '';
     }
   },
 
   /**
    * A utility function to compute the description for the category.
    * @param {string} category The category to show the description for.
-   * @param {boolean} categoryEnabled The state of the global toggle.
+   * @param {string} setting The string value of the setting.
    * @param {boolean} showRecommendation Whether to show the '(recommended)'
    *     label prefix.
    * @return {string} The category description.
    * @protected
    */
-  computeCategoryDesc: function(category, categoryEnabled, showRecommendation) {
+  computeCategoryDesc: function(category, setting, showRecommendation) {
+    var categoryEnabled = this.computeIsSettingEnabled(category, setting);
     switch (category) {
       case settings.ContentSettingsTypes.JAVASCRIPT:
         // "Allowed (recommended)" vs "Blocked".
         if (!categoryEnabled) {
           return loadTimeData.getString('siteSettingsBlocked');
         }
         return showRecommendation ?
             loadTimeData.getString('siteSettingsAllowedRecommended') :
             loadTimeData.getString('siteSettingsAllowed');
       case settings.ContentSettingsTypes.POPUPS:
@@ skipping 40 matching lines @@
             loadTimeData.getString('siteSettingsHandlersAskRecommended') :
             loadTimeData.getString('siteSettingsHandlersAsk');
       case settings.ContentSettingsTypes.IMAGES:
         if (!categoryEnabled) {
           return loadTimeData.getString('siteSettingsDontShowImages');
         }
         return showRecommendation ?
             loadTimeData.getString('siteSettingsShowAllRecommended') :
             loadTimeData.getString('siteSettingsShowAll');
       case settings.ContentSettingsTypes.PLUGINS:
-        // "Detect and run important content (recommended)" vs "Let me choose".
-        if (!categoryEnabled) {
-          return loadTimeData.getString('siteSettingsLetMeChoose');
-        }
-        return showRecommendation ?
-            loadTimeData.getString(
-                 'siteSettingsDetectAndRunImportantRecommended') :
-            loadTimeData.getString('siteSettingsDetectAndRunImportant');
+        if (setting == settings.PermissionValues.ALLOW)
+          return loadTimeData.getString('siteSettingsFlashAllow');
+        if (setting == settings.PermissionValues.BLOCK)
+          return loadTimeData.getString('siteSettingsFlashBlock');
+        return loadTimeData.getString('siteSettingsFlashAskBefore');

[Finnur, 2016/08/30 10:58:11]

Hmmm... I just noticed that when one presses Back (when on the Plugins  page),
the label under the category doesn't reflect the changes one has made on the
Site Category page. Meaning: if you change from Allow to Block, the label still
reads 'Allow flash' (paraphrasing).

This seems to be a problem for all categories and I feel this worked at one
point. Is it possible the routing changes caused this to happen, or am I
remembering incorrectly and this never worked?

[tommycli, 2016/08/30 16:53:42]

I noticed the same thing. Looking at the contents of site_settings_page.js, I'd
assume it never worked heh

       case settings.ContentSettingsTypes.BACKGROUND_SYNC:
         // "Allow sites to finish sending and receiving data" vs "Do not allow".
         if (!categoryEnabled) {
           return loadTimeData.getString('siteSettingsBackgroundSyncBlocked');
         }
         return showRecommendation ?
             loadTimeData.getString(
                  'siteSettingsAllowRecentlyClosedSitesRecommended') :
             loadTimeData.getString('siteSettingsAllowRecentlyClosedSites');
       case settings.ContentSettingsTypes.KEYGEN:
@@ skipping 107 matching lines @@
   computeIsSettingEnabled: function(category, setting) {
     // FullScreen is Allow vs. Ask.
     return category == settings.ContentSettingsTypes.FULLSCREEN ?
         setting != settings.PermissionValues.ASK :
         setting != settings.PermissionValues.BLOCK;
   },
 };
 
 /** @polymerBehavior */
 var SiteSettingsBehavior = [SiteSettingsBehaviorImpl];