Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 22802013: Remove access-check-failed callback after test. (Closed)

Created:
7 years, 4 months ago by Yang
Modified:
7 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Remove access-check-failed callback after test. BUG=v8:2848 R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16242

Patch Set 1 #

Patch Set 2 : added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M test/cctest/test-api.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
This solves part of V8 issue 2848. However, running out/ia32.debug/cctest test-api crashes with a segfault ...
7 years, 4 months ago (2013-08-19 16:42:17 UTC) #1
Toon Verwaest
lgtm
7 years, 4 months ago (2013-08-20 09:42:51 UTC) #2
Yang
7 years, 4 months ago (2013-08-20 10:46:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r16242.

Powered by Google App Engine
This is Rietveld 408576698