Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22802012: Rename DOMApplicationCache to ApplicationCache and expose it to JS (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, caseq+blink_chromium.org, aandrey+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Rename DOMApplicationCache to ApplicationCache and expose it to JS Rename DOMApplicationCache to ApplicationCache and expose it to JavaScript as per the latest specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/offline.html#applicationcache This is particularly useful as ApplicationCache exposes constant values. IE10 already exposes ApplicationCache to JavaScript while Firefox 23 does not. BUG=275669 R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156391

Patch Set 1 #

Total comments: 7

Patch Set 2 : Remove change to devtools and fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -337 lines) Patch
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/EventTarget.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EventTargetFactory.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/loader/appcache/ApplicationCache.h View 5 chunks +10 lines, -10 lines 0 comments Download
A + Source/core/loader/appcache/ApplicationCache.cpp View 4 chunks +16 lines, -16 lines 0 comments Download
A + Source/core/loader/appcache/ApplicationCache.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCacheHost.h View 3 chunks +4 lines, -4 lines 0 comments Download
D Source/core/loader/appcache/DOMApplicationCache.h View 1 chunk +0 lines, -92 lines 0 comments Download
D Source/core/loader/appcache/DOMApplicationCache.cpp View 1 chunk +0 lines, -140 lines 0 comments Download
D Source/core/loader/appcache/DOMApplicationCache.idl View 1 chunk +0 lines, -53 lines 0 comments Download
M Source/core/page/DOMWindow.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/page/DOMWindow.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/page/Window.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ApplicationCacheHost.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/web/ApplicationCacheHostInternal.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-19 15:25:19 UTC) #1
tkent
lgtm https://codereview.chromium.org/22802012/diff/1/Source/core/dom/EventTarget.h File Source/core/dom/EventTarget.h (right): https://codereview.chromium.org/22802012/diff/1/Source/core/dom/EventTarget.h#newcode42 Source/core/dom/EventTarget.h:42: class ApplicationCache; nit: sort alphabetically. https://codereview.chromium.org/22802012/diff/1/Source/core/page/DOMWindow.h File Source/core/page/DOMWindow.h ...
7 years, 4 months ago (2013-08-19 22:47:10 UTC) #2
do-not-use
https://codereview.chromium.org/22802012/diff/1/Source/devtools/front_end/externs.js File Source/devtools/front_end/externs.js (left): https://codereview.chromium.org/22802012/diff/1/Source/devtools/front_end/externs.js#oldcode179 Source/devtools/front_end/externs.js:179: DOMApplicationCache.prototype.UNCACHED = 0; On 2013/08/19 22:47:10, tkent wrote: > ...
7 years, 4 months ago (2013-08-20 06:09:16 UTC) #3
do-not-use
https://codereview.chromium.org/22802012/diff/1/Source/core/dom/EventTarget.h File Source/core/dom/EventTarget.h (right): https://codereview.chromium.org/22802012/diff/1/Source/core/dom/EventTarget.h#newcode42 Source/core/dom/EventTarget.h:42: class ApplicationCache; On 2013/08/19 22:47:10, tkent wrote: > nit: ...
7 years, 4 months ago (2013-08-20 06:17:29 UTC) #4
tkent
lgtm
7 years, 4 months ago (2013-08-20 06:18:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22802012/8001
7 years, 4 months ago (2013-08-20 06:19:46 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-20 06:28:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22802012/8001
7 years, 4 months ago (2013-08-20 09:20:30 UTC) #8
do-not-use
Committed patchset #2 manually as r156391 (presubmit successful).
7 years, 4 months ago (2013-08-20 12:40:13 UTC) #9
arv (Not doing code reviews)
7 years, 4 months ago (2013-08-20 13:57:13 UTC) #10
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698