Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Issue 2280153002: Refactoring out the code in LayoutTreeAsText::writeLayoutObject. (Closed)
Patch Set: Revert to Original Impl Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp b/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
index 132b41dd4999e9a53eec4d200af4eaa201f84790..98304416f805ff42bc95c6f30679aec39cac0f59 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
@@ -1041,4 +1041,28 @@ bool LayoutTableCell::backgroundIsKnownToBeOpaqueInRect(const LayoutRect& localR
return LayoutBlockFlow::backgroundIsKnownToBeOpaqueInRect(localRect);
}
+// TODO(lunalu): Deliberately dump the "inner" box of table cells, since that
+// is what current results reflect. We'd like to clean up the results to dump
+// both the outer box and the intrinsic padding so that both bits of
+// information are captured by the results.
+LayoutRect LayoutTableCell::debugRect() const
+{
+ LayoutRect rect = LayoutRect(
+ location().x(),
+ location().y() + intrinsicPaddingBefore(),
+ size().width(),
+ size().height() - intrinsicPaddingBefore() - intrinsicPaddingAfter());
+
+ LayoutBlock* cb = containingBlock();
+ if (cb)
+ cb->adjustChildDebugRect(rect);
+
+ return rect;
+}
+
+void LayoutTableCell::adjustChildDebugRect(LayoutRect& r) const
+{
+ r.move(0, -intrinsicPaddingBefore());
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698