Refactoring out the code in LayoutTreeAsText::writeLayoutObject.

third_party/WebKit/Source/core/layout/LayoutView.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 980 matching lines @@
     // normalized ScrollManager-like scrolling path and we should get rid of
     // of this override. All frame scrolling should be handled by
     // ViewportScrollCallback.
 
     if (!frameView())
         return ScrollResult(false, false, delta.width(), delta.height());
 
     return frameView()->getScrollableArea()->userScroll(granularity, delta);
 }
 
+LayoutRect LayoutView::debugRect() const
+{
+    LayoutRect rect;
+    LayoutBlock* block = containingBlock();
+    if (block)
+        block->adjustChildDebugRect(rect);

[skobes, 2016/09/12 17:09:35]

At this point, the rect is empty.  Should this be done after the width and
height are set?

[lunalu1, 2016/09/12 17:48:48]

I did this part according to the following code in LayoutTreeAsText.cpp:186-221.
And it seems like the adjustChildDebugRect() (as adjustForTableCells) was done
before setting the width and height for the LayoutView object.

    LayoutBlock* cb = o.containingBlock();
    bool adjustForTableCells = cb ? cb->isTableCell() : false;

    LayoutRect r;
    if (o.isText()) {
        ...
    } else if (o.isLayoutInline()) {
        ...
    } else if (o.isTableCell()) {
       ...
    } else if (o.isBox()) {
       ...
    }

    // FIXME: Temporary in order to ensure compatibility with existing layout
test results.
    if (adjustForTableCells)
        r.move(0,
-toLayoutTableCell(o.containingBlock())->intrinsicPaddingBefore());

    if (o.isLayoutView()) {
        r.setWidth(LayoutUnit(toLayoutView(o).viewWidth(IncludeScrollbars)));
        r.setHeight(LayoutUnit(toLayoutView(o).viewHeight(IncludeScrollbars)));
    }

[skobes, 2016/09/12 17:54:05]

I see.  I guess the order doesn't matter since adjustChildDebugRect doesn't care
about the size (and is temporary anyway), so this is ok.

[lunalu1, 2016/09/12 18:26:48]

Done.

+
+    rect.setWidth(LayoutUnit(viewWidth(IncludeScrollbars)));
+    rect.setHeight(LayoutUnit(viewHeight(IncludeScrollbars)));
+
+    return rect;
+}
+
 } // namespace blink