Refactoring out the code in LayoutTreeAsText::writeLayoutObject.

third_party/WebKit/Source/core/layout/LayoutObject.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 1348 matching lines @@
     // not including children which will be invalidated normally during invalidateTreeIfNeeded() and
     // parts which are invalidated separately (e.g. scrollbars).
     // The caller should ensure the painting layer has been setNeedsRepaint before calling this function.
     virtual void invalidateDisplayItemClients(PaintInvalidationReason) const;
 
     virtual bool hasNonCompositedScrollbars() const { return false; }
 
     // Called before anonymousChild.setStyle(). Override to set custom styles for the child.
     virtual void updateAnonymousChildStyle(const LayoutObject& anonymousChild, ComputedStyle& style) const { }
 
+    // Fixed implementation for LayoutText, LayoutInline, LayoutTableCell and

[skobes, 2016/09/09 20:27:41]

The comment should describe what the method does, e.g. "Returns a rect
corresponding to this LayoutObject's bounds for use in debugging output".  You
don't need to list the classes that override it.

[lunalu1, 2016/09/12 14:45:13]

Done.

+    // LayoutBox.
+    virtual LayoutRect debugRect() const
+    {
+        // This method should never be reached as it's overriden by subclasses.

[skobes, 2016/09/09 20:27:41]

Why not just make it pure virtual?  Then the compiler will catch any missing
overrides.

[lunalu1, 2016/09/12 14:45:14]

Then I have to write an overriding function for subclasses:
LayoutSVGGradientStop and LayoutSVGImage

[skobes, 2016/09/12 17:09:35]

If there are subclasses that don't override it, then why does it call
NOTREACHED()?

+        NOTREACHED();
+        LayoutRect r;
+        return r;
+    }
+
     // Painters can use const methods only, except for these explicitly declared methods.
     class MutableForPainting {
     public:
         void setPreviousPaintOffset(const LayoutPoint& paintOffset) { m_layoutObject.setPreviousPaintOffset(paintOffset); }
         void clearPaintInvalidationFlags() { m_layoutObject.clearPaintInvalidationFlags(); }
         void setShouldDoFullPaintInvalidation(PaintInvalidationReason reason) { m_layoutObject.setShouldDoFullPaintInvalidation(reason); }
         void ensureIsReadyForPaintInvalidation() { m_layoutObject.ensureIsReadyForPaintInvalidation(); }
 
         void setPreviousPaintInvalidationRect(const LayoutRect& r) { m_layoutObject.setPreviousPaintInvalidationRect(r); }
         void setPreviousPositionFromPaintInvalidationBacking(const LayoutPoint& p) { m_layoutObject.setPreviousPositionFromPaintInvalidationBacking(p); }
@@ skipping 759 matching lines @@
 void showTree(const blink::LayoutObject*);
 void showLineTree(const blink::LayoutObject*);
 void showLayoutTree(const blink::LayoutObject* object1);
 // We don't make object2 an optional parameter so that showLayoutTree
 // can be called from gdb easily.
 void showLayoutTree(const blink::LayoutObject* object1, const blink::LayoutObject* object2);
 
 #endif
 
 #endif // LayoutObject_h