Refactoring out the code in LayoutTreeAsText::writeLayoutObject.

third_party/WebKit/Source/core/layout/LayoutInline.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 1351 matching lines @@
 
 void LayoutInline::invalidateDisplayItemClients(PaintInvalidationReason invalidationReason) const
 {
     ObjectPaintInvalidator paintInvalidator(*this);
     paintInvalidator.invalidateDisplayItemClient(*this, invalidationReason);
 
     for (InlineFlowBox* box = firstLineBox(); box; box = box->nextLineBox())
         paintInvalidator.invalidateDisplayItemClient(*box, invalidationReason);
 }
 
+// FIXME: Would be better not to just dump 0, 0 as the x and y here.

[skobes, 2016/09/09 20:27:41]

It looks like this FIXME has been addressed?

[lunalu1, 2016/09/12 14:45:13]

Done.

+LayoutRect LayoutInline::debugRect() const
+{
+    IntRect linesBox = enclosingIntRect(linesBoundingBox());

[skobes, 2016/09/09 20:27:41]

Why aren't we just returning linesBoundingBox()?  This will lose subpixel
precision.

[lunalu1, 2016/09/12 14:45:13]

Done.

+    LayoutRect r = LayoutRect(IntRect(IntRect(linesBox.x(), linesBox.y(), linesBox.width(), linesBox.height())));

[skobes, 2016/09/09 20:27:41]

Remove redundant cast to IntRect.

[lunalu1, 2016/09/12 14:45:13]

Done.

+
+    return r;
+}
+
 } // namespace blink