Refactoring out the code in LayoutTreeAsText::writeLayoutObject.

third_party/WebKit/Source/core/layout/TracedLayoutObject.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/TracedLayoutObject.h"
 
 #include "core/layout/LayoutInline.h"
 #include "core/layout/LayoutTableCell.h"
 #include "core/layout/LayoutText.h"
 #include "core/layout/LayoutView.h"
@@ skipping 19 matching lines @@
                 for (size_t i = 0; i < element.classNames().size(); ++i)
                     tracedValue->pushString(element.classNames()[i]);
                 tracedValue->endArray();
             }
         }
     }
 
     // FIXME: When the fixmes in LayoutTreeAsText::writeLayoutObject() are
     // fixed, deduplicate it with this.
     if (traceGeometry) {
-        tracedValue->setDouble("absX", object.absoluteBoundingBoxRect().x());

[benjhayden, 2016/08/29 20:45:27]

Can you restore absX and absY? Sorry, I realize I accidentally asked you to
delete them, my bad. :-)

[lunalu1, 2016/08/30 20:35:30]

Done.

-        tracedValue->setDouble("absY", object.absoluteBoundingBoxRect().y());
-        LayoutRect rect;
-        if (object.isText())
-            rect = LayoutRect(toLayoutText(object).linesBoundingBox());
-        else if (object.isLayoutInline())
-            rect = LayoutRect(toLayoutInline(object).linesBoundingBox());
-        else if (object.isBox())
-            rect = toLayoutBox(&object)->frameRect();
+        LayoutRect rect = object.debugRect();
         tracedValue->setDouble("relX", rect.x());
         tracedValue->setDouble("relY", rect.y());
         tracedValue->setDouble("width", rect.width());
         tracedValue->setDouble("height", rect.height());
     } else {
         tracedValue->setDouble("absX", 0);
         tracedValue->setDouble("absY", 0);
         tracedValue->setDouble("relX", 0);
         tracedValue->setDouble("relY", 0);
         tracedValue->setDouble("width", 0);
@@ skipping 42 matching lines @@
 } // namespace
 
 std::unique_ptr<TracedValue> TracedLayoutObject::create(const LayoutView& view, bool traceGeometry)
 {
     std::unique_ptr<TracedValue> tracedValue = TracedValue::create();
     dumpToTracedValue(view, traceGeometry, tracedValue.get());
     return tracedValue;
 }
 
 } // namespace blink