Refactoring out the code in LayoutTreeAsText::writeLayoutObject.

third_party/WebKit/Source/core/layout/LayoutObject.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 59 matching lines @@
 #include "core/page/AutoscrollController.h"
 #include "core/page/Page.h"
 #include "core/paint/ObjectPaintInvalidator.h"
 #include "core/paint/ObjectPaintProperties.h"
 #include "core/paint/PaintLayer.h"
 #include "core/style/ContentData.h"
 #include "core/style/CursorData.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/TracedValue.h"
 #include "platform/geometry/TransformState.h"
+#include "platform/scroll/ScrollableArea.h"
 #include "wtf/allocator/Partitions.h"
 #include "wtf/text/StringBuilder.h"
 #include "wtf/text/WTFString.h"
 #include <algorithm>
 #include <memory>
 #ifndef NDEBUG
 #include <stdio.h>
 #endif
 
 namespace blink {
@@ skipping 3103 matching lines @@
 ObjectPaintProperties& LayoutObject::ensureObjectPaintProperties()
 {
     DCHECK(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
     auto addResult = objectPaintPropertiesMap().add(this, nullptr);
     if (addResult.isNewEntry)
         addResult.storedValue->value = ObjectPaintProperties::create();
 
     return *addResult.storedValue->value;
 }
 
+void LayoutObject::setLayoutRectDimForLayoutView(LayoutRect& rect) const
+{
+    if (isLayoutView()) {

[benjhayden, 2016/08/29 20:45:27]

Should this be moved to a virtual method so that LayoutView can override it?

[lunalu1, 2016/08/30 20:35:30]

Could you please clarify on this? So to create a virtual method that essentially
do nothing, but LayoutView override it to update the width and height? 

Can a LayoutObject be both a LayoutText/LayoutInline/LayoutTableCell/LayoutBox
and a LayoutView? 

+        rect.setWidth(LayoutUnit(toLayoutView(this)->viewWidth(IncludeScrollbars)));
+        rect.setHeight(LayoutUnit(toLayoutView(this)->viewHeight(IncludeScrollbars)));
+    }
+}
+
 } // namespace blink
 
 #ifndef NDEBUG
 
 void showTree(const blink::LayoutObject* object)
 {
     if (object)
         object->showTreeForThis();
     else
         WTFLogAlways("%s", "Cannot showTree. Root is (nil)");
@@ skipping 18 matching lines @@
         const blink::LayoutObject* root = object1;
         while (root->parent())
             root = root->parent();
         root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
     } else {
         WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");
     }
 }
 
 #endif