Refactoring out the code in LayoutTreeAsText::writeLayoutObject.

third_party/WebKit/Source/core/layout/LayoutBox.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  *           (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 4848 matching lines @@
     if (m_rareData && m_rareData->m_snapAreas) {
         m_rareData->m_snapAreas->remove(&snapArea);
     }
 }
 
 SnapAreaSet* LayoutBox::snapAreas() const
 {
     return m_rareData ? m_rareData->m_snapAreas.get() : nullptr;
 }
 
+LayoutRect LayoutBox::debugRect() const
+{
+    LayoutRect r = frameRect();
+
+    // FIXME: Temporary in order to ensure compatibility with existing layout
+    // test results.
+    LayoutBlock* cb = containingBlock();
+    if (cb && cb->isTableCell())

[benjhayden, 2016/08/29 20:45:27]

Should this be moved to a virtual method so that you don't need to check
isTableCell and then call toLayoutTableCell? 

[lunalu1, 2016/08/30 20:35:30]

I moved this part to a virtual method but I don't think I did it right. Could
you please be more clear about how to make this part virtual?

Thanks 

+        r.move(0, -toLayoutTableCell(containingBlock())->intrinsicPaddingBefore());
+
+    setLayoutRectDimForLayoutView(r);
+    return r;
+}
+
 } // namespace blink