chrome/browser/search_engines/search_terms_data.h - Issue 228013002: Use whether a query is from the app list to determine the RLZ parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/search_terms_data.h

Issue 228013002: Use whether a query is from the app list to determine the RLZ parameter. (Closed) Base URL: http://git.chromium.org/chromium/src.git@rlz-access-ids

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/base_search_provider.cc ('K') | « chrome/browser/autocomplete/history_url_provider.cc ('k') | chrome/browser/search_engines/search_terms_data.cc » ('j') | chrome/browser/search_engines/template_url_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search_engines/search_terms_data.h

diff --git a/chrome/browser/search_engines/search_terms_data.h b/chrome/browser/search_engines/search_terms_data.h

index feee80fec956c8f7cce9e57527d4a2fd098960d5..7167374166c0c9ed74a236a05e5e80dfe6827c62 100644

--- a/chrome/browser/search_engines/search_terms_data.h

+++ b/chrome/browser/search_engines/search_terms_data.h

@@ -34,7 +34,7 @@ class SearchTermsData {

// Returns the value for the Chrome Omnibox rlz. This implementation returns

// the empty string.

- virtual base::string16 GetRlzParameterValue() const;

+ virtual base::string16 GetRlzParameterValue(bool from_app_list) const;

// The optional client parameter passed with Google search requests. This

// implementation returns the empty string.

@@ -71,7 +71,8 @@ class UIThreadSearchTermsData : public SearchTermsData {

virtual std::string GoogleBaseURLValue() const OVERRIDE;

virtual std::string GetApplicationLocale() const OVERRIDE;

- virtual base::string16 GetRlzParameterValue() const OVERRIDE;

+ virtual base::string16 GetRlzParameterValue(bool from_app_list) const

+ OVERRIDE;

virtual std::string GetSearchClient() const OVERRIDE;

virtual std::string GetSuggestClient() const OVERRIDE;

virtual std::string GetSuggestRequestIdentifier() const OVERRIDE;