Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: chrome/browser/search_engines/search_terms_data.cc

Issue 228013002: Use whether a query is from the app list to determine the RLZ parameter. (Closed) Base URL: http://git.chromium.org/chromium/src.git@rlz-access-ids
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/search_terms_data.cc
diff --git a/chrome/browser/search_engines/search_terms_data.cc b/chrome/browser/search_engines/search_terms_data.cc
index 8e8d6f881af719fdbb75c5c4eba80cbed403b592..7c6e0d7257efa1eca4053b732a21fe20e4878625 100644
--- a/chrome/browser/search_engines/search_terms_data.cc
+++ b/chrome/browser/search_engines/search_terms_data.cc
@@ -60,7 +60,7 @@ std::string SearchTermsData::GetApplicationLocale() const {
return "en";
}
-base::string16 SearchTermsData::GetRlzParameterValue() const {
+base::string16 SearchTermsData::GetRlzParameterValue(bool from_app_list) const {
return base::string16();
}
@@ -109,7 +109,8 @@ std::string UIThreadSearchTermsData::GetApplicationLocale() const {
// Android implementations are located in search_terms_data_android.cc.
#if !defined(OS_ANDROID)
-base::string16 UIThreadSearchTermsData::GetRlzParameterValue() const {
+base::string16 UIThreadSearchTermsData::GetRlzParameterValue(
+ bool from_app_list) const {
DCHECK(!BrowserThread::IsThreadInitialized(BrowserThread::UI) ||
BrowserThread::CurrentlyOn(BrowserThread::UI));
base::string16 rlz_string;
@@ -122,7 +123,12 @@ base::string16 UIThreadSearchTermsData::GetRlzParameterValue() const {
// This call will return false the first time(s) it is called until the
// value has been cached. This normally would mean that at most one omnibox
// search might not send the RLZ data but this is not really a problem.
- RLZTracker::GetAccessPointRlz(RLZTracker::CHROME_OMNIBOX, &rlz_string);
+ rlz_lib::AccessPoint access_point = RLZTracker::CHROME_OMNIBOX;
+#if !defined(OS_IOS)
+ if (from_app_list)
+ access_point = RLZTracker::CHROME_APP_LIST;
+#endif
+ RLZTracker::GetAccessPointRlz(access_point, &rlz_string);
}
#endif
return rlz_string;
« no previous file with comments | « chrome/browser/search_engines/search_terms_data.h ('k') | chrome/browser/search_engines/search_terms_data_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698