Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: third_party/WebKit/Source/core/paint/BoxPainter.cpp

Issue 2280123002: Fix under-invalidation of media buffered ranges (Closed)
Patch Set: Synchronize buffered ranges when the current play time changes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/BoxPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/BoxPainter.cpp b/third_party/WebKit/Source/core/paint/BoxPainter.cpp
index 8018fbde2898f03faef02d3d739bd4cc220de992..d9b751983bdc767ef174b3fb6cdd1ace3ee3f58b 100644
--- a/third_party/WebKit/Source/core/paint/BoxPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/BoxPainter.cpp
@@ -103,16 +103,12 @@ void BoxPainter::paintBoxDecorationBackgroundWithRect(const PaintInfo& paintInfo
bool paintingOverflowContents = isPaintingBackgroundOfPaintContainerIntoScrollingContentsLayer(&m_layoutBox, paintInfo);
const ComputedStyle& style = m_layoutBox.styleRef();
- // FIXME: For now we don't have notification on media buffered range change from media player
- // and miss paint invalidation on buffered range change. crbug.com/484288.
+ // We may paint a delayed-invalidation object before it's actually invalidated. Note this would be handled for
+ // us by LayoutObjectDrawingRecorder but we have to use DrawingRecorder as we may use the scrolling contents
+ // layer as DisplayItemClient below.
Optional<DisplayItemCacheSkipper> cacheSkipper;
- if (style.appearance() == MediaSliderPart
- // We may paint a delayed-invalidation object before it's actually invalidated. Note this would be handled for
- // us by LayoutObjectDrawingRecorder but we have to use DrawingRecorder as we may use the scrolling contents
- // layer as DisplayItemClient below.
- || m_layoutBox.fullPaintInvalidationReason() == PaintInvalidationDelayedFull) {
+ if (m_layoutBox.fullPaintInvalidationReason() == PaintInvalidationDelayedFull)
cacheSkipper.emplace(paintInfo.context);
- }
const DisplayItemClient& displayItemClient = paintingOverflowContents ? static_cast<const DisplayItemClient&>(*m_layoutBox.layer()->compositedLayerMapping()->scrollingContentsLayer()) : m_layoutBox;
if (DrawingRecorder::useCachedDrawingIfPossible(paintInfo.context, displayItemClient, DisplayItem::BoxDecorationBackground))

Powered by Google App Engine
This is Rietveld 408576698