Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2280063002: [asm.js] (Re)use temporaries in asm->wasm conversion. (Closed)

Created:
4 years, 3 months ago by titzer
Modified:
4 years, 3 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[asm.js] (Re)use temporaries in asm->wasm conversion. This CL is a prequisite for the stack machine changes, which will need to use temporaries in various places due to the stack height requirements on blocks. R=ahaas@chromium.org,bradnelson@chromium.org BUG= Committed: https://crrev.com/b5cbcb357fda86045e15247a6c89f01ff772eac2 Cr-Commit-Position: refs/heads/master@{#39001}

Patch Set 1 #

Total comments: 1

Patch Set 2 : [asm.js] (Re)use temporaries in asm->wasm conversion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -17 lines) Patch
M src/asmjs/asm-wasm-builder.cc View 4 chunks +16 lines, -16 lines 0 comments Download
M src/wasm/encoder.h View 1 1 chunk +44 lines, -0 lines 0 comments Download
M src/wasm/encoder.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
titzer
4 years, 3 months ago (2016-08-26 12:33:07 UTC) #1
bradnelson
lgtm https://codereview.chromium.org/2280063002/diff/1/src/wasm/encoder.h File src/wasm/encoder.h (right): https://codereview.chromium.org/2280063002/diff/1/src/wasm/encoder.h#newcode187 src/wasm/encoder.h:187: ZoneVector<uint32_t>* vector_; temporary_?
4 years, 3 months ago (2016-08-29 16:04:24 UTC) #6
titzer
On 2016/08/29 16:04:24, bradnelson wrote: > lgtm > > https://codereview.chromium.org/2280063002/diff/1/src/wasm/encoder.h > File src/wasm/encoder.h (right): > ...
4 years, 3 months ago (2016-08-30 09:06:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280063002/20001
4 years, 3 months ago (2016-08-30 09:09:06 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 09:42:39 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 09:43:15 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b5cbcb357fda86045e15247a6c89f01ff772eac2
Cr-Commit-Position: refs/heads/master@{#39001}

Powered by Google App Engine
This is Rietveld 408576698