gyp/skia_for_chromium_defines.gypi - Issue 2280053002: Restrict supported font formats in Chrome context

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gyp/skia_for_chromium_defines.gypi

Issue 2280053002: Restrict supported font formats in Chrome context (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 Google Inc.	1 # Copyright 2014 Google Inc.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # This file is included by chrome's skia/skia_common.gypi, and is intended to	5 # This file is included by chrome's skia/skia_common.gypi, and is intended to

6 # augment the skia flags that are set there.	6 # augment the skia flags that are set there.

7	7

8 {	8 {

9 'variables': {	9 'variables': {

10	10

11 # These flags will be defined in chromium	11 # These flags will be defined in chromium

12 #	12 #

13 # If these become 'permanent', they should be moved into skia_common.gypi	13 # If these become 'permanent', they should be moved into skia_common.gypi

14 #	14 #

15 'skia_for_chromium_defines': [	15 'skia_for_chromium_defines': [

16 'SK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS',	16 'SK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS',

	17 'SK_RESTRICT_FONT_FORMATS_OPENTYPE'
	bungeman-skia 2016/08/26 15:52:36 This define should live in <chromium>/src/skia/con This define should live in <chromium>/src/skia/config/SkUserConfig.h or <chromium>/src/skia/BUILD.gn:skia_library_config defines. This file is more of a temporary place to land defines, it's not really intended for long term use. In fact, I'm not sure why the other one is currently hanging around in here. For consistency this define should be named SK_FONT_CONFIG_INTERFACE_ONLY_ALLOW_SFNT_FONTS since I think that's what is actually wanted. Though it might be more accurate to state which tables are required (cmap, hmtx). drott 2016/08/26 16:19:04 Define renamed to SK_FONT_CONFIG_INTERFACE_ONLY_AL Define renamed to SK_FONT_CONFIG_INTERFACE_ONLY_ALLOW_SFNT_FONTS
17 ],	18 ],

18 },	19 },

19 }	20 }

OLD	NEW

« no previous file with comments | « no previous file | src/ports/SkFontConfigInterface_direct.cpp » ('j') | src/ports/SkFontConfigInterface_direct.cpp » ('J')