Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2280033003: [Mac] Update the AppMenu Error icon (Closed)

Created:
4 years, 3 months ago by spqchan
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Update the AppMenu Error icon Menu should use the new browser tools error icon. BUG=630354 Committed: https://crrev.com/09a373d94b03acf20ec60f35dd73de708e31d468 Cr-Commit-Position: refs/heads/master@{#414791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/global_error/global_error.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
spqchan
PTAL
4 years, 3 months ago (2016-08-26 18:10:59 UTC) #3
Nico
lgtm
4 years, 3 months ago (2016-08-26 18:16:18 UTC) #4
spqchan
On 2016/08/26 18:16:18, Nico wrote: > lgtm thanks!
4 years, 3 months ago (2016-08-26 18:17:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280033003/1
4 years, 3 months ago (2016-08-26 18:18:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 20:16:21 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 20:18:05 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09a373d94b03acf20ec60f35dd73de708e31d468
Cr-Commit-Position: refs/heads/master@{#414791}

Powered by Google App Engine
This is Rietveld 408576698