Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: src/ast/scopes.h

Issue 2280033002: Move Parser::Declare to Scope. (Closed)
Patch Set: code review (verwaest@) Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | src/ast/scopes.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/scopes.h
diff --git a/src/ast/scopes.h b/src/ast/scopes.h
index 8a84664c18ec44d657ebc85db9208c98d3b66c5f..2af59105e364e68136c1334f9d0d58e66e17506a 100644
--- a/src/ast/scopes.h
+++ b/src/ast/scopes.h
@@ -141,6 +141,12 @@ class Scope: public ZoneObject {
InitializationFlag init_flag, Variable::Kind kind,
MaybeAssignedFlag maybe_assigned_flag = kNotAssigned);
+ Variable* DeclareVariable(Declaration* declaration, VariableMode mode,
+ InitializationFlag init,
+ bool allow_harmony_restrictive_generators,
+ bool* sloppy_mode_block_scope_function_redefinition,
+ bool* ok);
+
// Declarations list.
ZoneList<Declaration*>* declarations() { return &decls_; }
@@ -185,11 +191,6 @@ class Scope: public ZoneObject {
// TODO(verwaest): Move to DeclarationScope?
Variable* NewTemporary(const AstRawString* name);
- // Adds the specific declaration node to the list of declarations in
- // this scope. The declarations are processed as part of entering
- // the scope; see codegen.cc:ProcessDeclarations.
- void AddDeclaration(Declaration* declaration);
-
// ---------------------------------------------------------------------------
// Illegal redeclaration support.
« no previous file with comments | « no previous file | src/ast/scopes.cc » ('j') | src/ast/scopes.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698