Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9794)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 228003006: Remove dependency on --gc-sections for most Android debug targets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nits Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/chrome_android.gypi ('K') | « chrome/chrome_android.gypi ('k') | components/policy/policy_browser.gypi » ('j') | content/content_tests.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_tests_unit.gypi
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index 2b1f522d8f80992f94fe87a6997438781da42fc0..9d51f87163114ecad0e1cccb9fa7fc19ea2b904f 100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -281,8 +281,6 @@
'test/ppapi/ppapi_test.h',
'../ui/gfx/image/image_unittest_util.cc',
'../ui/gfx/image/image_unittest_util.h',
- '../webkit/browser/quota/mock_special_storage_policy.cc',
- '../webkit/browser/quota/mock_special_storage_policy.h',
],
'conditions': [
['OS!="ios"', {
@@ -2448,6 +2446,11 @@
'dependencies!': [
'../third_party/libaddressinput/libaddressinput.gyp:libaddressinput',
],
+ 'ldflags': [
+ # Some android targets depend on --gc-sections to link.
+ # Force --gc-sections also for Debug builds (see crbug.com/159847).
Nico 2014/04/11 20:36:59 todo here too
Primiano Tucci (use gerrit) 2014/04/14 17:22:27 Done.
+ '-Wl,--gc-sections',
+ ],
'sources!': [
# Bookmark export/import are handled via the BookmarkColumns
# ContentProvider.
« chrome/chrome_android.gypi ('K') | « chrome/chrome_android.gypi ('k') | components/policy/policy_browser.gypi » ('j') | content/content_tests.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698