Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4342)

Unified Diff: chrome/chrome_android.gypi

Issue 228003006: Remove dependency on --gc-sections for most Android debug targets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nits Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_android.gypi
diff --git a/chrome/chrome_android.gypi b/chrome/chrome_android.gypi
index 48e8cdb08593cb8da12b1da5aaf9ae45a6136f23..f900f1c039b45454af897b6cb07ba1325a9209fb 100644
--- a/chrome/chrome_android.gypi
+++ b/chrome/chrome_android.gypi
@@ -44,6 +44,13 @@
'dependencies': [
'../base/allocator/allocator.gyp:allocator', ],
}],
+ ['OS=="android"', {
+ 'ldflags': [
+ # Some android targets depend on --gc-sections to link.
+ # Force --gc-sections also for Debug builds (see crbug.com/159847).
+ '-Wl,--gc-sections',
Nico 2014/04/11 20:36:59 The idea is to remove this too eventually, right (
Primiano Tucci (use gerrit) 2014/04/12 10:26:00 Right. However the chrome layer on Android is damn
+ ],
+ }],
],
},
{
« no previous file with comments | « build/common.gypi ('k') | chrome/chrome_tests_unit.gypi » ('j') | chrome/chrome_tests_unit.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698