fix #27155, do not push down dynamic as context type

fix #27155, do not push down dynamic as context type

R=leafp@google.com

Committed: https://github.com/dart-lang/sdk/commit/9bdf0dadd439a3946233e1049649e078995eaf7c

[Jennifer Messerly, 2016-08-26 23:37:27]

jmesserly@google.com changed reviewers:
+ leafp@google.com

[Jennifer Messerly, 2016-08-26 23:37:28]

I couldn't come up with a test that is actually fixed by this, but it seems like
maybe worth adding as a cleanup?

https://codereview.chromium.org/2280023004/diff/1/pkg/analyzer/test/src/task/...
File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right):

https://codereview.chromium.org/2280023004/diff/1/pkg/analyzer/test/src/task/...
pkg/analyzer/test/src/task/strong/inferred_type_test.dart:1721: void
test_futureUnion_downwardsGenericMethods() {
just a sorting change

[Leaf, 2016-08-29 18:01:38]

lgtm

[Jennifer Messerly, 2016-08-29 19:57:33]

Hi Leaf, could you take another look? It's much improved. Pray I do not improve
it further! ;)

[Leaf, 2016-08-29 22:11:09]

lgtm

https://codereview.chromium.org/2280023004/diff/40001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/type_system.dart (right):

https://codereview.chromium.org/2280023004/diff/40001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/type_system.dart:1686: * For a similar reason
`Future<T> | Future<Future<T>>` is equivalent to just
I think the answer is yes, but just to be sure... will this change be backwards
compatible with the .then<Future<T>> workaround that we had people using before?
 That is, will this still work:

Future<int> f;
f.then<Future<List<int>>>((x) => []);

?

[Jennifer Messerly, 2016-08-29 22:23:07]

thanks!

https://codereview.chromium.org/2280023004/diff/40001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/type_system.dart (right):

https://codereview.chromium.org/2280023004/diff/40001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/type_system.dart:1686: * For a similar reason
`Future<T> | Future<Future<T>>` is equivalent to just
On 2016/08/29 22:11:09, Leaf wrote:
> I think the answer is yes, but just to be sure... will this change be
backwards
> compatible with the .then<Future<T>> workaround that we had people using
before?
>  That is, will this still work:
> 
> Future<int> f;
> f.then<Future<List<int>>>((x) => []);
> 
> ?

added a test, but yeah, it works.

the return type of Future.then<S> is Future<S>, so in this case is
Future<Future<List<int>>> which == Future<List<int>>. Then we call flatten on
that to extract the type arg, leaving us with List<int>. Then we create the
future union.

[Jennifer Messerly, 2016-08-29 22:24:55]

Description was changed from

==========
fix #27155, do not push down dynamic as context type
==========

to

==========
fix #27155, do not push down dynamic as context type

R=leafp@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9bdf0dadd439a3946233e1049649e078995eaf7c
==========

[Jennifer Messerly, 2016-08-29 22:24:57]

Committed patchset #4 (id:60001) manually as
9bdf0dadd439a3946233e1049649e078995eaf7c (presubmit successful).