Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2279973002: Converted Observatory heap-map element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Updated observatory_sources.gypi #

Patch Set 3 : Fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -159 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 2 1 chunk +14 lines, -7 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_map.dart View 7 chunks +163 lines, -97 lines 0 comments Download
D runtime/observatory/lib/src/elements/heap_map.html View 1 chunk +0 lines, -44 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
cbernaschina
4 years, 3 months ago (2016-08-26 00:55:39 UTC) #2
cbernaschina
4 years, 3 months ago (2016-08-26 00:57:28 UTC) #3
rmacnak
lgtm
4 years, 3 months ago (2016-08-26 16:40:41 UTC) #4
cbernaschina
4 years, 3 months ago (2016-08-26 17:00:40 UTC) #5
cbernaschina
4 years, 3 months ago (2016-08-26 17:00:57 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
bdbd443317561e47e59006eb9804b97907b7de8c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698