Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: scripts/slave/zip_build.py

Issue 2279953002: lightweight builds archiving for mac and win64 (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: lightweight builds archiving for mac and win64 Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/zip_build.py
diff --git a/scripts/slave/zip_build.py b/scripts/slave/zip_build.py
index 49dbf37c7254c29441b99cf7839e63a923f31884..7bcda873ec6afe64914945fb2815cf54ed118013 100755
--- a/scripts/slave/zip_build.py
+++ b/scripts/slave/zip_build.py
@@ -170,6 +170,8 @@ def MakeUnversionedArchive(build_dir, staging_dir, zip_file_list,
zip_file_name, strip_files=None):
"""Creates an unversioned full build archive.
Returns the path of the created archive."""
+ # Prevents having zip_file_list to contain duplicates
+ zip_file_list = list(set(zip_file_list))
(zip_dir, zip_file) = chromium_utils.MakeZip(staging_dir,
zip_file_name,
zip_file_list,
@@ -270,11 +272,11 @@ class PathMatcher(object):
self.inclusions = CommaStrParser(options.include_files)
self.exclusions = (CommaStrParser(options.exclude_files)
+ chromium_utils.FileExclusions())
-
self.regex_whitelist = FileRegexWhitelist(options)
self.regex_blacklist = FileRegexBlacklist(options)
self.exclude_unmatched = options.exclude_unmatched
- self.ignore_regex = options.ignore_regex
+ self.exclude_extra = options.exclude_extra
+ self.custom_whitelist = options.whitelist
def __str__(self):
return '\n '.join([
@@ -284,7 +286,8 @@ class PathMatcher(object):
"Whitelist regex: '%s'" % self.regex_whitelist,
"Blacklist regex: '%s'" % self.regex_blacklist,
'Zip unmatched files: %s' % (not self.exclude_unmatched),
- 'Ignore regex matches: %s' % self.ignore_regex])
+ 'Exclude extra: %s' % self.exclude_extra,
+ "Custom Whitelist regex: '%s'" % self.custom_whitelist])
def Match(self, filename):
@@ -292,7 +295,10 @@ class PathMatcher(object):
return True
if filename in self.exclusions:
return False
- if self.ignore_regex:
+ if (self.custom_whitelist and
+ re.match(self.custom_whitelist, filename)):
+ return True
+ if self.exclude_extra:
return False
if re.match(self.regex_whitelist, filename):
return True
@@ -422,8 +428,11 @@ def main(argv):
option_parser.add_option('--include-files', default='',
help='Comma separated list of files that should '
'always be included in the zip.')
- option_parser.add_option('--ignore-regex', action='store_true',
- default=False, help='Ignores regex matches')
+ option_parser.add_option('--whitelist', default='',
+ help='Custom regex whitelist to include files')
+ option_parser.add_option('--exclude-extra', action='store_true',
+ default=False, help='Only includes include file list and '
ghost stip (do not use) 2016/08/30 23:48:53 nit: 80 chars
miimnk 2016/08/31 00:19:05 Done.
+ 'regex whitelist match provided')
option_parser.add_option('--master-name', help='Name of the buildbot master.')
option_parser.add_option('--slave-name', help='Name of the buildbot slave.')
option_parser.add_option('--build-number', type=int,

Powered by Google App Engine
This is Rietveld 408576698