Chromium Code Reviews| Index: scripts/slave/recipe_modules/archive/api.py |
| diff --git a/scripts/slave/recipe_modules/archive/api.py b/scripts/slave/recipe_modules/archive/api.py |
| index bdf1c40b33f73b139539bc815ed134901697354d..bd443dd5b0319ceaf5d731bda30629b7411aff04 100644 |
| --- a/scripts/slave/recipe_modules/archive/api.py |
| +++ b/scripts/slave/recipe_modules/archive/api.py |
| @@ -3,6 +3,7 @@ |
| # found in the LICENSE file. |
| import re |
| +import sys |
| import manual_bisect_files |
|
ghost stip (do not use)
2016/08/31 16:38:27
nit: put a space between system imports and local
|
| from recipe_engine import recipe_api |
| @@ -92,7 +93,8 @@ class ArchiveApi(recipe_api.RecipeApi): |
| self, step_name, target, build_url=None, src_dir=None, |
| build_revision=None, cros_board=None, package_dsym_files=False, |
| exclude_files=None, exclude_perf_test_files=False, |
| - update_properties=None, store_by_hash=True, **kwargs): |
| + update_properties=None, store_by_hash=True, |
| + platform=None, **kwargs): |
| """Returns a step invoking zip_build.py to zip up a Chromium build. |
| If build_url is specified, also uploads the build.""" |
| if not src_dir: |
| @@ -121,12 +123,23 @@ class ArchiveApi(recipe_api.RecipeApi): |
| args.extend(['--exclude-files', exclude_files]) |
| if 'gs_acl' in self.m.properties: |
| args.extend(['--gs-acl', self.m.properties['gs_acl']]) |
| - if exclude_perf_test_files: |
| - inclusions = ','.join(manual_bisect_files.CHROME_REQUIRED_FILES) |
| - strip_files = ','.join(manual_bisect_files.CHROME_STRIP_LIST) |
| - args.extend(['--include-files', inclusions]) |
| - args.extend(['--ignore-regex']) |
| - args.extend(['--strip-files', strip_files]) |
| + if exclude_perf_test_files and platform: |
| + include_bisect_file_list = (manual_bisect_files. |
|
ghost stip (do not use)
2016/08/31 16:38:27
nit: move the line down and indent so it looks lik
|
| + get_required_files(platform)) |
| + include_bisect_strip_list = (manual_bisect_files. |
| + get_strip_files(platform)) |
| + include_bisect_whitelist = (manual_bisect_files. |
| + get_whitelist_files(platform)) |
| + if include_bisect_file_list: |
| + inclusions = ','.join(include_bisect_file_list) |
| + args.extend(['--include-files', inclusions]) |
| + if include_bisect_strip_list: |
| + strip_files = ','.join(include_bisect_strip_list) |
| + args.extend(['--strip-files', strip_files]) |
| + if include_bisect_whitelist: |
| + args.extend(['--whitelist', include_bisect_whitelist]) |
| + args.extend(['--not-include-extra']) |
| + |
| # If update_properties is passed in and store_by_hash is False, |
| # we store it with commit position number instead of a hash |
| if update_properties and not store_by_hash: |