Don't check for chrome.exe when initializing crash reporting

chrome_elf/elf_imports_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 #include <windows.h>
 
 #include <algorithm>
 #include <vector>
 
 #include "base/base_paths.h"
+#include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/files/file_path.h"
 #include "base/files/memory_mapped_file.h"
 #include "base/path_service.h"
 #include "base/strings/pattern.h"
 #include "base/strings/string_util.h"
+#include "base/test/launcher/test_launcher.h"
 #include "base/win/pe_image.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 class ELFImportsTest : public testing::Test {
  protected:
   static bool ImportsCallback(const base::win::PEImage &image,
                               LPCSTR module,
                               PIMAGE_THUNK_DATA name_table,
@@ skipping 28 matching lines @@
 // depends on a relatively small portion of base. In GYP, this works in debug
 // builds as well because static libraries are used for the sandbox and base
 // targets and the files that use e.g. user32.dll happen to not get brought
 // into the build in the first place (due to the way static libraries are
 // linked where only the required .o files are included). But we don't bother
 // differentiating GYP and GN builds for this purpose.
 //
 // If you break this test, you may have changed base or the Windows sandbox
 // such that more system imports are required to link.
 #if defined(NDEBUG) && !defined(COMPONENT_BUILD)
+
 TEST_F(ELFImportsTest, ChromeElfSanityCheck) {
   base::FilePath dll;
   ASSERT_TRUE(PathService::Get(base::DIR_EXE, &dll));
   dll = dll.Append(L"chrome_elf.dll");
 
   std::vector<std::string> elf_imports;
   GetImports(dll, &elf_imports);
 
   // Check that ELF has imports.
   ASSERT_LT(0u, elf_imports.size()) << "Ensure the chrome_elf_unittests "
@@ skipping 20 matching lines @@
     bool match = false;
     for (const char* kValidFilePattern : kValidFilePatterns) {
       if (base::MatchPattern(import, kValidFilePattern)) {
         match = true;
         break;
       }
     }
     ASSERT_TRUE(match) << "Illegal import in chrome_elf.dll: " << import;
   }
 }
+
 TEST_F(ELFImportsTest, ChromeElfLoadSanityTest) {
+  // chrome_elf will try to launch crashpad_handler by reinvoking the current
+  // binary with --type=crashpad-handler if not already running that way. To
+  // avoid that, we relaunch and run the real test body manually, adding that
+  // command line argument, as we're only trying to confirm that user32.dll
+  // doesn't get loaded by import table when chrome_elf.dll does.
+  base::CommandLine new_test =
+      base::CommandLine(base::CommandLine::ForCurrentProcess()->GetProgram());
+  new_test.AppendSwitchASCII(
+      base::kGTestFilterFlag,
+      "ELFImportsTest.DISABLED_ChromeElfLoadSanityTestImpl");
+  new_test.AppendSwitchASCII("type", "crashpad-handler");
+  new_test.AppendSwitch("gtest_also_run_disabled_tests");
+  new_test.AppendSwitch("single-process-tests");
+
+  std::string output;
+  ASSERT_TRUE(base::GetAppOutput(new_test, &output));
+  std::string crash_string =
+      "OK ] ELFImportsTest.DISABLED_ChromeElfLoadSanityTestImpl";
+
+  if (output.find(crash_string) == std::string::npos) {
+    GTEST_FAIL() << "Couldn't find\n" << crash_string << "\n in output\n "
+                 << output;
+  }
+}
+
+// Note: This test is not actually disabled, it's just tagged disabled so that
+// the real run (above, in ChromeElfLoadSanityTest) can run it with an argument
+// added to the command line.
+TEST_F(ELFImportsTest, DISABLED_ChromeElfLoadSanityTestImpl) {
   base::FilePath dll;
   ASSERT_TRUE(PathService::Get(base::DIR_EXE, &dll));
   dll = dll.Append(L"chrome_elf.dll");
 
   // We don't expect user32 to be loaded in chrome_elf_unittests. If this test
   // case fails, then it means that a dependency on user32 has crept into the
   // chrome_elf_unittests executable, which needs to be removed.
   EXPECT_EQ(nullptr, ::GetModuleHandle(L"user32.dll"));
 
   HMODULE chrome_elf_module_handle = ::LoadLibrary(dll.value().c_str());
   EXPECT_TRUE(chrome_elf_module_handle != nullptr);
   // Loading chrome_elf.dll should not load user32.dll
   EXPECT_EQ(nullptr, ::GetModuleHandle(L"user32.dll"));
   EXPECT_TRUE(!!::FreeLibrary(chrome_elf_module_handle));
 }
-#endif  // NDEBUG
+
+#endif  // NDEBUG && !COMPONENT_BUILD
 
 TEST_F(ELFImportsTest, ChromeExeSanityCheck) {
   std::vector<std::string> exe_imports;
 
   base::FilePath exe;
   ASSERT_TRUE(PathService::Get(base::DIR_EXE, &exe));
   exe = exe.Append(L"chrome.exe");
   GetImports(exe, &exe_imports);
 
   // Check that chrome.exe has imports.
   ASSERT_LT(0u, exe_imports.size()) << "Ensure the chrome_elf_unittests "
     "target was built, instead of chrome_elf_unittests.exe";
 
   // Chrome.exe's first import must be ELF.
   EXPECT_EQ("chrome_elf.dll", exe_imports[0]) <<
       "Illegal import order in chrome.exe (ensure the chrome_elf_unittest "
       "target was built, instead of just chrome_elf_unittests.exe)";
 }
 
 }  // namespace