Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2279913002: Start processing immediately if there is network (Closed)

Created:
4 years, 3 months ago by Pete Williamson
Modified:
4 years, 3 months ago
Reviewers:
dougarnett
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start processing immediately if there is network BUG=610521 Committed: https://crrev.com/a8a40f8baa6a8cdf727332f3ef398570a59d631d Cr-Commit-Position: refs/heads/master@{#414586}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -2 lines) Patch
M components/offline_pages/background/request_coordinator.h View 2 chunks +14 lines, -0 lines 0 comments Download
M components/offline_pages/background/request_coordinator.cc View 3 chunks +31 lines, -0 lines 1 comment Download
M components/offline_pages/background/request_coordinator_unittest.cc View 3 chunks +25 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Pete Williamson
4 years, 3 months ago (2016-08-25 20:50:35 UTC) #2
dougarnett
lgtm https://codereview.chromium.org/2279913002/diff/1/components/offline_pages/background/request_coordinator.cc File components/offline_pages/background/request_coordinator.cc (right): https://codereview.chromium.org/2279913002/diff/1/components/offline_pages/background/request_coordinator.cc#newcode193 components/offline_pages/background/request_coordinator.cc:193: RequestCoordinator::GetConnectionType() { indentation?
4 years, 3 months ago (2016-08-25 21:03:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279913002/1
4 years, 3 months ago (2016-08-25 21:06:26 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/269110)
4 years, 3 months ago (2016-08-25 22:45:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2279913002/1
4 years, 3 months ago (2016-08-25 23:09:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 23:46:08 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 23:49:55 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a8a40f8baa6a8cdf727332f3ef398570a59d631d
Cr-Commit-Position: refs/heads/master@{#414586}

Powered by Google App Engine
This is Rietveld 408576698