Make the new index page more useful

Make the new index page more useful

This also makes use of the /permissions endpoint

BUG=631047
Committed: https://github.com/luci/luci-py/commit/02c221379d625677c7ccfacebd86cfca4be15518

[kjlubick, 2016-08-26 17:28:00]

kjlubick@google.com changed reviewers:
+ jcgregorio@chromium.org, stephana@chromium.org

[kjlubick, 2016-08-26 17:28:01]

Live at
https://2288-384b2db-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newui/

Nothing super fancy here.

What it looks like for admins:
https://screenshot.googleplex.com/MuzewWcduFP

And non-admins:
https://screenshot.googleplex.com/WMLEUQ8QSzf

[jcgregorio, 2016-08-26 18:29:07]

jcgregorio@google.com changed reviewers:
+ jcgregorio@google.com

[jcgregorio, 2016-08-26 18:29:08]

https://codereview.chromium.org/2279903002/diff/20001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/swarming-app.html (right):

https://codereview.chromium.org/2279903002/diff/20001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/swarming-app.html:23: client_id:
String, Oauth 2.0 client id.  It will be set by server-side
Looks like it's currently hard-coded, is that intentional?

https://codereview.chromium.org/2279903002/diff/20001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/swarming-app.html:27: authHeaders:
Object, Use this as an argument to sk.request to set oauth2 headers.
Sorry, I missed this in previous reviews, don't use mixed case for properties.
Instead use underscores, i.e. "auth_headers". That way you can grep for the same
thing in HTML and JS. Should probably add that to our styleguide.

Can be done in a separate CL.

[kjlubick, 2016-08-26 18:39:26]

https://codereview.chromium.org/2279903002/diff/20001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/common/swarming-app.html (right):

https://codereview.chromium.org/2279903002/diff/20001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/swarming-app.html:23: client_id:
String, Oauth 2.0 client id.  It will be set by server-side
On 2016/08/26 at 18:29:08, jcgregorio wrote:
> Looks like it's currently hard-coded, is that intentional?

It's hardcoded in the demos (unless I missed it somewhere else?).  In
staging/prod the server sets it. 
https://github.com/luci/luci-py/blob/0be022d38c8efbb5add3933ba1cc89cc22340db3...

https://codereview.chromium.org/2279903002/diff/20001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/common/swarming-app.html:27: authHeaders:
Object, Use this as an argument to sk.request to set oauth2 headers.
On 2016/08/26 at 18:29:08, jcgregorio wrote:
> Sorry, I missed this in previous reviews, don't use mixed case for properties.
Instead use underscores, i.e. "auth_headers". That way you can grep for the same
thing in HTML and JS. Should probably add that to our styleguide.
> 
> Can be done in a separate CL.

This was actually a typo of sorts.  I fixed the names in auth-signin (which had
been ported from elsewhere).

[jcgregorio, 2016-08-26 18:44:29]

lgtm

[KevinL, 2016-08-26 19:25:29]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-08-26 19:25:30]

lgtm

[kjlubick, 2016-08-26 19:25:58]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-08-26 19:26:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 19:29:22]

Description was changed from

==========
Make the new index page more useful

This also makes use of the /permissions endpoint

BUG=631047
==========

to

==========
Make the new index page more useful

This also makes use of the /permissions endpoint

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/02c221379d625677c7ccfacebd86cfca4be15518
==========

[commit-bot: I haz the power, 2016-08-26 19:29:24]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/02c221379d625677c7ccfacebd86cfca4be15518