Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issue 22799023: Fix call of finalized virtual function. (Closed)

Created:
7 years, 4 months ago by kilvadyb
Modified:
7 years, 4 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

Fix call of finalized virtual function. In the RegExpUnparser::VisitText(RegExpText* that, void* data) function always RegExpUnparser::VisitAtom function called via that->elements()->at(i).data.u_atom->Accept(this, data); even if the type of the object is RegExpCharacterClass. The problem comes up using g++ 4.7(.2, .3) sice r16232. Tested on MIPS and x64: Program received signal SIGSEGV, Segmentation fault. 0x0000000000588928 in v8::internal::RegExpUnparser::VisitAtom(v8::internal::RegExpAtom*, void*) () BUG= TEST=cctest/test-regexp/ParserRegression

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/ast.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kilvadyb
7 years, 4 months ago (2013-08-22 19:25:45 UTC) #1
Paul Lind
Thanks Balázs. I separately verified that this segfault occurs on ia32, x64 (and arm, mips ...
7 years, 4 months ago (2013-08-22 23:24:08 UTC) #2
Benedikt Meurer
Please test the following: 1.) Build with C++11 enabled (i.e. CXXFLAGS=-std=c++11). 2.) Try to remove ...
7 years, 4 months ago (2013-08-23 08:59:29 UTC) #3
Benedikt Meurer
On 2013/08/23 08:59:29, Benedikt Meurer wrote: > Please test the following: > > 1.) Build ...
7 years, 4 months ago (2013-08-23 09:27:22 UTC) #4
Benedikt Meurer
7 years, 4 months ago (2013-08-23 10:29:00 UTC) #5
On 2013/08/23 09:27:22, Benedikt Meurer wrote:
> On 2013/08/23 08:59:29, Benedikt Meurer wrote:
> > Please test the following:
> > 
> > 1.) Build with C++11 enabled (i.e. CXXFLAGS=-std=c++11).
> > 2.) Try to remove the V8_FINAL declaration from RegExpAtom.
> 
> Forget about it. You spotted a bug in V8 here. I'll prepare a fix. :-)

See https://codereview.chromium.org/22815033/

Powered by Google App Engine
This is Rietveld 408576698