Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 22799021: Fix hidden properties on object with frozen prototype. (Closed)

Created:
7 years, 4 months ago by Michael Starzinger
Modified:
7 years, 4 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fix hidden properties on object with frozen prototype. This fixes a corner-case where a frozen prototype with existing hidden properties might prevent setting hidden properties on another object. R=rossberg@chromium.org BUG=v8:2829 Committed: http://code.google.com/p/v8/source/detail?r=16276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -42 lines) Patch
M src/objects.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.cc View 10 chunks +22 lines, -21 lines 0 comments Download
A + test/mjsunit/regress/regress-2829.js View 1 chunk +21 lines, -19 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 4 months ago (2013-08-22 13:14:29 UTC) #1
rossberg
lgtm
7 years, 4 months ago (2013-08-22 13:25:08 UTC) #2
Michael Starzinger
7 years, 4 months ago (2013-08-22 13:51:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16276.

Powered by Google App Engine
This is Rietveld 408576698