Web Animations CSS: Support Animation of StyleImage and LengthBox

Source/core/animation/AnimatableImage.h

Index: Source/core/animation/AnimatableImage.h
diff --git a/Source/core/animation/AnimatableImage.h b/Source/core/animation/AnimatableImage.h
new file mode 100644
index 0000000000000000000000000000000000000000..18c8757361f4f9dca2cebd9a019e4cdaf2686703
--- /dev/null
+++ b/Source/core/animation/AnimatableImage.h
@@ -0,0 +1,74 @@
+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef AnimatableImage_h
+#define AnimatableImage_h
+
+#include "core/animation/AnimatableValue.h"
+#include "core/css/CSSCrossfadeValue.h"
+#include "core/rendering/style/StyleGeneratedImage.h"

[Timothy Loh, 2013/08/27 04:26:06]

I think you only use this in the .cpp

[dstockwell, 2013/08/27 05:02:02]

Done.

+#include "core/rendering/style/StyleImage.h"
+
+namespace WebCore {
+
+class AnimatableImage : public AnimatableValue {
+public:
+    virtual ~AnimatableImage() { }
+    static PassRefPtr<AnimatableImage> create(StyleImage* image)
+    {
+        return adoptRef(new AnimatableImage(image));
+    }
+    PassRefPtr<CSSValue> toCSSValue() const { return m_image->cssValue(); }
+    StyleImage* toStyleImage() const { return m_image.get(); }

[Timothy Loh, 2013/08/27 04:26:06]

Maybe const StyleImage*?

[dstockwell, 2013/08/27 05:02:02]

no viable conversion from 'const WebCore::StyleImage *' to
'PassRefPtr<WebCore::StyleImage>

+
+protected:
+    virtual PassRefPtr<AnimatableValue> interpolateTo(const AnimatableValue* other, double fraction) const OVERRIDE;
+    virtual PassRefPtr<AnimatableValue> addWith(const AnimatableValue*) const OVERRIDE;
+
+private:
+    AnimatableImage(StyleImage* image)
+        : AnimatableValue(TypeImage)
+        , m_image(image)
+    {
+        ASSERT(m_image);
+    }
+
+    RefPtr<StyleImage> m_image;

[Timothy Loh, 2013/08/27 04:26:06]

Perhaps const RefPtr if possible.

[dstockwell, 2013/08/27 05:02:02]

Done.

+};
+
+inline const AnimatableImage* toAnimatableImage(const AnimatableValue* value)
+{
+    ASSERT_WITH_SECURITY_IMPLICATION(value && value->isImage());
+    return static_cast<const AnimatableImage*>(value);
+}
+
+} // namespace WebCore
+
+#endif // AnimatableNumber_h