LayoutTests/animations/interpolation/clip-interpolation-expected.txt - Issue 22799020: Web Animations CSS: Support Animation of StyleImage and LengthBox

Side by Side Diff: LayoutTests/animations/interpolation/clip-interpolation-expected.txt

Issue 22799020: Web Animations CSS: Support Animation of StyleImage and LengthBox (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix baselines for new test. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/animations/interpolation/clip-interpolation.html ('k') | LayoutTests/virtual/web-animations-css/animations/interpolation/clip-interpolation-expected.txt » ('j') | Source/core/css/resolver/AnimatedStyleBuilder.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 clip from [rect(0px, 75px, 80px, 10px)] to [rect(0px, 100px, 90px, 5px)] was [re ct(0px 50px 70px 15px)] at -1

	2 clip from [rect(0px, 75px, 80px, 10px)] to [rect(0px, 100px, 90px, 5px)] was [re ct(0px 75px 80px 10px)] at 0

	3 clip from [rect(0px, 75px, 80px, 10px)] to [rect(0px, 100px, 90px, 5px)] was [re ct(0px 87.5px 85px 7.5px)] at 0.5

	4 clip from [rect(0px, 75px, 80px, 10px)] to [rect(0px, 100px, 90px, 5px)] was [re ct(0px 100px 90px 5px)] at 1

	5 clip from [rect(0px, 75px, 80px, 10px)] to [rect(0px, 100px, 90px, 5px)] was [re ct(0px 112.5px 95px 2.5px)] at 1.5

	6 clip from [rect(auto, auto, auto, 10px)] to [rect(20px, 50px, 50px, auto)] was [ rect(20px 50px 50px 0px)] at 0.4
	Timothy Loh 2013/08/27 05:48:17 Why is this right? Shouldn't we have rect(auto, au Why is this right? Shouldn't we have rect(auto, auto, auto, 10px) here? (Actually it looks like we don't handle getComputedStyle for auto components correctly, so rect(0px, 0px, 0px, 10px)). Also we might want a test where there are both unmatched (auto/px) pairs and matched (px/px) pairs. Timothy Loh 2013/08/27 05:59:54 Also we probably want to test animating from auto Also we probably want to test animating from auto to rect(...) and vice versa. I suspect we may be doing the wrong thing in these cases since we aren't calling setHasClip anywhere here (the StyleBuilder should setHasClip(false) when you pass it auto, but we won't be setting it to true when we setClip(...) after the 50% step). dstockwell 2013/08/27 06:26:23 This is just the expectation, it's not right. The Show quoted text On 2013/08/27 05:48:17, Timothy Loh wrote: > Why is this right? Shouldn't we have rect(auto, auto, auto, 10px) here? This is just the expectation, it's not right. The existing implementation steps at 0% not 50%. Our results are in the virtual/web-animations-css directory. Show quoted text > (Actually it looks like we don't handle getComputedStyle for auto components > correctly, so rect(0px, 0px, 0px, 10px)). Also we might want a test where there > are both unmatched (auto/px) pairs and matched (px/px) pairs. Done. dstockwell 2013/08/27 06:26:23 That's why I was setting the clip: property on all Show quoted text On 2013/08/27 05:59:54, Timothy Loh wrote: > Also we probably want to test animating from auto to rect(...) and vice versa. I > suspect we may be doing the wrong thing in these cases since we aren't calling > setHasClip anywhere here (the StyleBuilder should setHasClip(false) when you > pass it auto, but we won't be setting it to true when we setClip(...) after the > 50% step). That's why I was setting the clip: property on all elements ahead of the animation. I've added a test for this behavior. We currently match the existing implementation but should be able to fix both at the same time.
	7 clip from [rect(auto, auto, auto, 10px)] to [rect(20px, 50px, 50px, auto)] was [ rect(20px 50px 50px 0px)] at 0.6

	8

OLD	NEW