Issue 22799016: Kill NOTIFICATION_EXTENSION_REMOVED

Issue 22799016: Kill NOTIFICATION_EXTENSION_REMOVED (Closed)

Created:
7 years, 4 months ago by Cait (Slow)

Modified:
4 years, 8 months ago

Reviewers:
Yoyo Zhou, darin (slow to review)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Kill NOTIFICATION_EXTENSION_REMOVED BUG=268984 TEST= no change TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219659

Patch Set 4 : Move CB removal calls to dtor. #

Patch Set 6 : Nit #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+120 lines, -45 lines)			Patch
M	chrome/browser/chrome_notification_types.h	View	1 2 3	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_disabled_ui.cc	View	1 2 3 4 5	8 chunks	+42 lines, -17 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.h	View	1 2 3	4 chunks	+13 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	1 2 3	4 chunks	+26 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/external_install_ui.cc	View	1 2 3 4	5 chunks	+39 lines, -12 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

https://codereview.chromium.org/22799016/diff/20001/chrome/browser/extensions/extension_disabled_ui.cc File chrome/browser/extensions/extension_disabled_ui.cc (right): https://codereview.chromium.org/22799016/diff/20001/chrome/browser/extensions/extension_disabled_ui.cc#newcode349 chrome/browser/extensions/extension_disabled_ui.cc:349: service_->RemoveExtensionRemovedCallback(on_removed_callback_); Seems like this should be in the destructor ...

7 years, 4 months ago (2013-08-22 16:50:25 UTC) #2

Cait (Slow)

7 years, 3 months ago (2013-08-26 18:01:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/22799016/26001

7 years, 3 months ago (2013-08-26 21:07:41 UTC) #5

ckocagil

Reverted due to Linux ASAN breakage. http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASAN%20Tests%20%281%29&number=17314 http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASAN%20Tests%20%282%29&number=16432

7 years, 3 months ago (2013-08-27 02:44:42 UTC) #7

Cait (Slow)

yoz@ : Would you mind taking another quick look at this? (First try got rolled ...

7 years, 3 months ago (2013-08-27 21:13:14 UTC) #8

LGTM, thanks

Expand Messages | Collapse Messages